[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D18319: Improve LiveDataDock and import widget
From:       Christoph Roick <noreply () phabricator ! kde ! org>
Date:       2019-01-30 9:53:07
Message-ID: 479e5b7a244e1cf9690801f71164f660 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

croick marked an inline comment as done.
croick added inline comments.

INLINE COMMENTS

> asemke wrote in MainWin.cpp:1923
> this piece of code you removed now made sure we don't connect to the same broker twice. Here \
> we also showed an message to the user to make this clear. To me it make sense. We should \
> maybe adapt this logic and extend it to other data sources, too. Was there any reason to \
> remove this logic? You partially moved this logic to LiveDataDock::setMQTTClient(), right?

Initially I removed this, because there was no check for the port, which makes this check \
exclude more hosts than required, but then I added that logic in the dock widget. In my opinion \
it should be up to the user to manage the number of distinct clients. There might be a reason \
to split them. I would show a warning at most, but let the user decide if it still is what was \
intended.

On the other hand, that should not be part of this patch. So I will take it back in (including \
a check for the port number).

REPOSITORY
  R262 LabPlot

REVISION DETAIL
  https://phabricator.kde.org/D18319

To: croick, #labplot
Cc: sgerlach, asemke, kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">croick marked an inline comment as done.<br />croick added inline \
comments. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px \
solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18319">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: \
6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: \
0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; \
margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: \
hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D18319#inline-103193">View Inline</a><span style="color: \
#4b4d51; font-weight: bold;">asemke</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">MainWin.cpp:1923</span></div> <div style="margin: 8px 0; padding: 0 12px; color: \
#74777D;"><p style="padding: 0; margin: 8px;">this piece of code you removed now made sure we \
don&#039;t connect to the same broker twice. Here we also showed an message to the user to make \
this clear. To me it make sense. We should maybe adapt this logic and extend it to other data \
sources, too. Was there any reason to remove this logic? You partially moved this logic to \
LiveDataDock::setMQTTClient(), right?</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">Initially I removed this, because there was no check \
for the port, which makes this check exclude more hosts than required, but then I added that \
logic in the dock widget.<br /> In my opinion it should be up to the user to manage the number \
of distinct clients. There might be a reason to split them. I would show a warning at most, but \
let the user decide if it still is what was intended.</p>

<p style="padding: 0; margin: 8px;">On the other hand, that should not be part of this patch. \
So I will take it back in (including a check for the port \
number).</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R262 \
LabPlot</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D18319">https://phabricator.kde.org/D18319</a></div></div><br \
/><div><strong>To: </strong>croick, LabPlot<br /><strong>Cc: </strong>sgerlach, asemke, \
kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]