[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D18476: Fixing
From:       Alexander Semke <noreply () phabricator ! kde ! org>
Date:       2019-01-26 16:59:30
Message-ID: 426efe0a67f413151076d4c98cdf55f9 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

asemke accepted this revision.
asemke added a comment.
This revision is now accepted and ready to land.


  Looks good now. I'll add additional escaping in QRegularExpression in DateTimeSpinBox to get rid of \
compiler warnings and push your fix.

REVISION DETAIL
  https://phabricator.kde.org/D18476

To: Murmele, asemke
Cc: sgerlach, yurchor, kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">asemke accepted this revision.<br />asemke added a comment.<br />This revision is \
now accepted and ready to land. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px \
8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D18476">View Revision</a></tr></table><br \
/><div><div><p>Looks good now. I&#039;ll add additional escaping in QRegularExpression in DateTimeSpinBox \
to get rid of compiler warnings and push your fix.</p></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D18476">https://phabricator.kde.org/D18476</a></div></div><br \
/><div><strong>To: </strong>Murmele, asemke<br /><strong>Cc: </strong>sgerlach, yurchor, kde-edu, \
narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]