[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D18510: Ring-field focusing feature.
From: Eric Dejouhanet <noreply () phabricator ! kde ! org>
Date: 2019-01-25 8:46:27
Message-ID: 9a29bb30fd863934858faa08ab46b101 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.
REVISION SUMMARY
Adds inner and outer limits to filter stars when running a full-frame focus \
procedure. When option "Full Field" is enabled in the Focus tab, the procedure will \
first detect stars that are visible on the frame, using either the SEP method (if \
selected) or the Centroid method, and remove stars not in the ring surface bounded \
by the inner and outer radius values before calculating the mean HFR.
TEST PLAN
Basic items:
- Default options are "Sub Frame", and inner/outer radius boxes disabled.
- Selecting "Full Frame" enables the radius boxes, default values are 0% and 100%, \
respectively.
- Tooltips are coherent, and match their gadgets.
- Enabling "Sub Frame" disables "Full Frame", and enabling "Full Frame" disables \
"Sub Frame".
- Procedure values and selection are remembered from one execution of KStars to the \
other.
Procedure:
- Filter use is enabled with option "Full Frame".
- Filter is inoperant if inner/outer radius value are 0% and 100%, respectively.
- If one of the radius values is not the default, the filter is used.
- When the filter is used, two blue dashed circles are displayed on the focus frame \
(values 0% and 100% are not visible).
- Stars inside the inner circle are disregarded for the focus procedure, and are \
not marked by the star overlay.
- Stars outside the outer circle are disregarded for the focus procedure, and are \
not marked by the star overlay.
REPOSITORY
R321 KStars
BRANCH
feature__ring_frame_focusing (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18510
AFFECTED FILES
kstars/ekos/focus/focus.cpp
kstars/ekos/focus/focus.ui
kstars/fitsviewer/fitsdata.cpp
kstars/fitsviewer/fitsdata.h
kstars/fitsviewer/fitsview.cpp
kstars/fitsviewer/fitsview.h
kstars/kstars.kcfg
To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol
[Attachment #3 (text/html)]
<table><tr><td style="">TallFurryMan created this revision.<br />TallFurryMan added \
reviewers: mutlaqja, wreissenberger.<br />Herald added a project: KDE Edu.<br \
/>Herald added a subscriber: kde-edu.<br />TallFurryMan requested review of this \
revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D18510">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Adds inner and outer limits to filter \
stars when running a full-frame focus procedure.<br /> When option "Full \
Field" is enabled in the Focus tab, the procedure will first detect<br /> stars \
that are visible on the frame, using either the SEP method (if selected) or the<br /> \
Centroid method, and remove stars not in the ring surface bounded by the inner and<br \
/> outer radius values before calculating the mean HFR.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Basic items:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Default options are "Sub Frame", and \
inner/outer radius boxes disabled.</li> <li class="remarkup-list-item">Selecting \
"Full Frame" enables the radius boxes, default values are 0% and 100%, \
respectively.</li> <li class="remarkup-list-item">Tooltips are coherent, and match \
their gadgets.</li> <li class="remarkup-list-item">Enabling "Sub Frame" \
disables "Full Frame", and enabling "Full Frame" disables \
"Sub Frame".</li> <li class="remarkup-list-item">Procedure values and \
selection are remembered from one execution of KStars to the other.</li> </ul>
<p>Procedure:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Filter use is enabled with option "Full \
Frame".</li> <li class="remarkup-list-item">Filter is inoperant if inner/outer \
radius value are 0% and 100%, respectively.</li> <li class="remarkup-list-item">If \
one of the radius values is not the default, the filter is used.</li> <li \
class="remarkup-list-item">When the filter is used, two blue dashed circles are \
displayed on the focus frame (values 0% and 100% are not visible).</li> <li \
class="remarkup-list-item">Stars inside the inner circle are disregarded for the \
focus procedure, and are not marked by the star overlay.</li> <li \
class="remarkup-list-item">Stars outside the outer circle are disregarded for the \
focus procedure, and are not marked by the star overlay.</li> </ul></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>feature__ring_frame_focusing (branched from \
master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D18510">https://phabricator.kde.org/D18510</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>kstars/ekos/focus/focus.cpp<br /> \
kstars/ekos/focus/focus.ui<br /> kstars/fitsviewer/fitsdata.cpp<br />
kstars/fitsviewer/fitsdata.h<br />
kstars/fitsviewer/fitsview.cpp<br />
kstars/fitsviewer/fitsview.h<br />
kstars/kstars.kcfg</div></div></div><br /><div><strong>To: </strong>TallFurryMan, \
mutlaqja, wreissenberger<br /><strong>Cc: </strong>kde-edu, narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic