[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D17850: Tutorial screen added for odd even activity
From: Johnny Jazeix <noreply () phabricator ! kde ! org>
Date: 2018-12-29 16:34:39
Message-ID: a941bb1cdd1c385e20d7470eb9bc2851 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
jjazeix added inline comments.
INLINE COMMENTS
> planegame.js:53
> + {
> + "instruction": qsTr("Odd numbers are those numbers which do not \
> leaves remainder 0 when divisible by 2."), + "instructionQml": \
> "qrc:/gcompris/src/activities/planegame/resource/tutorial.qml"
do not leave
> tutorial.qml:1
> +
> +
missing copyright
> tutorial.qml:15
> + anchors.centerIn: parent.Center
> + text: "For example: \n 15, 19, 51 , 65 , 103 , \n 119 , 169 , 185 , 505 , \
> 533 , \n 701 , 799 , 845 , 897 , 1001. \n All of these numbers are odd numbers as \
> they \n do not leave remainder 0 when divisible by 2." + font.pixelSize: \
> parent.height * 0.1
missing qsTr() for strings to translate
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D17850
To: dekumar, #gcompris_improvements
Cc: jjazeix, yurchor, kde-edu, narvaez, apol
[Attachment #3 (text/html)]
<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D17850">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D17850#inline-98157">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">planegame.js:53</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: \
#766510">"instruction"</span><span style="color: #aa2211">:</span> <span \
style="color: #004012">qsTr</span><span class="p">(</span><span style="color: \
#766510">"Odd numbers are those numbers which do not leaves remainder 0 when \
divisible by 2."</span><span class="p">),</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #766510">"instructionQml"</span><span style="color: \
#aa2211">:</span> <span style="color: \
#766510">"qrc:/gcompris/src/activities/planegame/resource/tutorial.qml"</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">do \
not leave</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D17850#inline-98158">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">tutorial.qml:1</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; color: \
#888888;">(Empty.)</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">missing copyright</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D17850#inline-98159">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">tutorial.qml:15</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">anchors.centerIn:</span> <span style="color: \
#004012">parent</span><span class="p">.</span><span style="color: \
#004012">Center</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span \
style="color: #766510">"For example: \n 15, 19, 51 , 65 , 103 , \n 119 , 169 , \
185 , 505 , 533 , \n 701 , 799 , 845 , 897 , 1001. \n All of these numbers are odd \
numbers as they \n do not leave remainder 0 when divisible by 2."</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">font.pixelSize:</span> <span style="color: \
#004012">parent</span><span class="p">.</span><span style="color: \
#004012">height</span> <span style="color: #aa2211">*</span> <span style="color: \
#601200">0.1</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">missing qsTr() for strings to translate</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17850">https://phabricator.kde.org/D17850</a></div></div><br \
/><div><strong>To: </strong>dekumar, GCompris: Improvements<br /><strong>Cc: \
</strong>jjazeix, yurchor, kde-edu, narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic