[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D17626: Print preview for KmPlot
From:       Yuri Chornoivan <noreply () phabricator ! kde ! org>
Date:       2018-12-24 16:33:00
Message-ID: 3d1a1710e537c923927ba32718f81b04 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

yurchor marked 2 inline comments as done.
yurchor added inline comments.

INLINE COMMENTS

> tcanabrava wrote in maindlg.cpp:703-704
> If you are creating them here to delete them in the end of the function, why don't \
> you create them on the stack?

The same pattern can be found above.

Just for other possible reviewers, the discussions on this topic can be found by the \
following addresses

https://blogs.kde.org/node/3919

https://phabricator.kde.org/D7285

https://phabricator.kde.org/D17697

It seems that this is a questionable decision but it might be of some sense. Thanks \
in advance for your opinions.

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D17626

To: yurchor, #kde_edu, tcanabrava
Cc: tcanabrava, kde-doc-english, kde-edu, skadinna, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">yurchor marked 2 inline comments as done.<br />yurchor added \
inline comments. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 \
8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D17626">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D17626#inline-97675">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">tcanabrava</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">maindlg.cpp:703-704</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">If you are creating them here to delete them in the end of the function, why \
don&#039;t you create them on the stack?</p></div></div> <div style="margin: 8px 0; \
padding: 0 12px;"><p style="padding: 0; margin: 8px;">The same pattern can be found \
above.</p>

<p style="padding: 0; margin: 8px;">Just for other possible reviewers, the \
discussions on this topic can be found by the following addresses</p>

<p style="padding: 0; margin: 8px;"><a href="https://blogs.kde.org/node/3919" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://blogs.kde.org/node/3919</a></p>

<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/D7285" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/D7285</a></p>

<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/D17697" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/D17697</a></p>

<p style="padding: 0; margin: 8px;">It seems that this is a questionable decision but \
it might be of some sense. Thanks in advance for your \
opinions.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R334 KmPlot</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17626">https://phabricator.kde.org/D17626</a></div></div><br \
/><div><strong>To: </strong>yurchor, KDE Edu, tcanabrava<br /><strong>Cc: \
</strong>tcanabrava, kde-doc-english, kde-edu, skadinna, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]