[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D17720: Allow direct link to the help page when the "Help" button is pressed in the settings window
From:       Yuri Chornoivan <noreply () phabricator ! kde ! org>
Date:       2018-12-24 14:30:15
Message-ID: cc5a77938ad650edb49b9b73c7f4280c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

yurchor added inline comments.

INLINE COMMENTS

> tcanabrava wrote in mainwindow.cpp:114
> It was for you.
> ABI means Application Binary Interface, that means that if you change something, applications that \
> depend on that something will break, but the MainWindow is not in a library, it's the application, so \
> changing things inside of the application doesn't needs to keep ABI.  only in shared libraries.

So what is the way to proceed? Rewrite this as it is in Okular (the only known semi-working \
implementation)?

https://cgit.kde.org/okular.git/tree/conf/preferencesdialog.cpp

Thanks in advance for your advice.

REPOSITORY
  R327 Kanagram

REVISION DETAIL
  https://phabricator.kde.org/D17720

To: yurchor, #kde_edu
Cc: tcanabrava, apol, kde-edu, narvaez


[Attachment #3 (text/html)]

<table><tr><td style="">yurchor added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; \
font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D17720">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: \
solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px \
8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D17720#inline-97689">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">tcanabrava</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">mainwindow.cpp:114</span></div> <div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p \
style="padding: 0; margin: 8px;">It was for you.<br /> ABI means Application Binary Interface, that means \
that if you change something, applications that depend on that something will break, but the MainWindow \
is not in a library, it&#039;s the application, so changing things inside of the application doesn&#039;t \
needs to keep ABI. <br /> only in shared libraries.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">So what is the way to \
proceed? Rewrite this as it is in Okular (the only known semi-working implementation)?</p>

<p style="padding: 0; margin: 8px;"><a \
href="https://cgit.kde.org/okular.git/tree/conf/preferencesdialog.cpp" class="remarkup-link" \
target="_blank" rel="noreferrer">https://cgit.kde.org/okular.git/tree/conf/preferencesdialog.cpp</a></p>

<p style="padding: 0; margin: 8px;">Thanks in advance for your \
advice.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R327 \
Kanagram</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17720">https://phabricator.kde.org/D17720</a></div></div><br \
/><div><strong>To: </strong>yurchor, KDE Edu<br /><strong>Cc: </strong>tcanabrava, apol, kde-edu, \
narvaez<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]