[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D17275: Fixed UI in Color Mix
From:       Johnny Jazeix <noreply () phabricator ! kde ! org>
Date:       2018-12-18 14:56:50
Message-ID: 7d7de2dbb7358fa48a578b4d5aab567c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

jjazeix closed this revision.
jjazeix added a comment.


  Sorry for delay, I fixed other issues within the patch:
  
  - when you submit an answer, you may have 3 texts displayed on the right that was \
                hidden by the light (too much color/not enough color...)
  - I put the score on the left to avoid potential overriding and having a floating \
                score
  - I set a max value for the circle radius to avoid having it going too big.
  
  Pushed in https://commits.kde.org/gcompris/6801db8c71046c34ea619a6ff7e8b559ee5a99f2
  Thank you!

REVISION DETAIL
  https://phabricator.kde.org/D17275

To: varunp, #gcompris_improvements, amankumargupta
Cc: jjazeix, amankumargupta, kde-edu, #gcompris, harrymecwan, ganeshredcobra, \
nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, \
hkaelberer, bcoudoin


[Attachment #3 (text/html)]

<table><tr><td style="">jjazeix closed this revision.<br />jjazeix added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D17275">View Revision</a></tr></table><br \
/><div><div><p>Sorry for delay, I fixed other issues within the patch:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">when you submit an answer, you may have 3 texts \
displayed on the right that was hidden by the light (too much color/not enough \
color...)</li> <li class="remarkup-list-item">I put the score on the left to avoid \
potential overriding and having a floating score</li> <li \
class="remarkup-list-item">I set a max value for the circle radius to avoid having it \
going too big.</li> </ul>

<p>Pushed in <a href="https://commits.kde.org/gcompris/6801db8c71046c34ea619a6ff7e8b559ee5a99f2" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://commits.kde.org/gcompris/6801db8c71046c34ea619a6ff7e8b559ee5a99f2</a><br \
/> Thank you!</p></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17275">https://phabricator.kde.org/D17275</a></div></div><br \
/><div><strong>To: </strong>varunp, GCompris: Improvements, amankumargupta<br \
/><strong>Cc: </strong>jjazeix, amankumargupta, kde-edu, GCompris, harrymecwan, \
ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, \
timotheegiet, hkaelberer, bcoudoin<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]