[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D17559: Prepare Kalzium components (liscience and compound viewer) for compiling with -DQT_NO_CAST_F
From:       Yuri Chornoivan <noreply () phabricator ! kde ! org>
Date:       2018-12-15 11:26:16
Message-ID: 9e2247d00b56e8ee0ca55d895e457e8e () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

yurchor abandoned this revision.
yurchor added a comment.


  In D17559#377363 <https://phabricator.kde.org/D17559#377363>, @aacid wrote:
  
  > I really doubt QT_NO_CAST_FROM_ASCII will even be default even mandatory.
  
  
  Ok. Thanks.
  
  I had started the final step of removing kdelibs4support with
  
    include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)
  
  in CMakeLists.txt. Taking the wrong way, I decided to add QLatin1String() and \
Q_SLOT everywhere. Even tried to patch libavogadro:  
  https://github.com/OpenChemistry/avogadrolibs/pull/414
  
  It appears that things are much simpler and porting was deadly easy. ;)
  
  https://cgit.kde.org/kalzium.git/commit/?id=1c906b21a6b5d1f80a6a93b4cf384239d125ada4
  
  https://cgit.kde.org/kalzium.git/commit/?id=c000bb62873bf5cdcd8ee3394e947336e6d859f2
  
  Then I decided to do something with the patched parts... It's good to know they are \
actually not necessary. :)

REPOSITORY
  R326 Kalzium

REVISION DETAIL
  https://phabricator.kde.org/D17559

To: yurchor, #kde_edu
Cc: aacid, kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">yurchor abandoned this revision.<br />yurchor added a \
comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D17559">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D17559#377363" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D17559#377363</a>, <a \
href="https://phabricator.kde.org/p/aacid/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>I really doubt QT_NO_CAST_FROM_ASCII will \
even be default even mandatory.</p></div> </blockquote>

<p>Ok. Thanks.</p>

<p>I had started the final step of removing kdelibs4support with</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, \
0.08);">include(KDEFrameworkCompilerSettings NO_POLICY_SCOPE)</pre></div>

<p>in CMakeLists.txt. Taking the wrong way, I decided to add QLatin1String() and \
Q_SLOT everywhere. Even tried to patch libavogadro:</p>

<p><a href="https://github.com/OpenChemistry/avogadrolibs/pull/414" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://github.com/OpenChemistry/avogadrolibs/pull/414</a></p>

<p>It appears that things are much simpler and porting was deadly easy. ;)</p>

<p><a href="https://cgit.kde.org/kalzium.git/commit/?id=1c906b21a6b5d1f80a6a93b4cf384239d125ada4" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://cgit.kde.org/kalzium.git/commit/?id=1c906b21a6b5d1f80a6a93b4cf384239d125ada4</a></p>


<p><a href="https://cgit.kde.org/kalzium.git/commit/?id=c000bb62873bf5cdcd8ee3394e947336e6d859f2" \
class="remarkup-link" target="_blank" \
rel="noreferrer">https://cgit.kde.org/kalzium.git/commit/?id=c000bb62873bf5cdcd8ee3394e947336e6d859f2</a></p>


<p>Then I decided to do something with the patched parts... It&#039;s good to know \
they are actually not necessary. :)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R326 Kalzium</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17559">https://phabricator.kde.org/D17559</a></div></div><br \
/><div><strong>To: </strong>yurchor, KDE Edu<br /><strong>Cc: </strong>aacid, \
kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]