[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D17110: checks for alpha value too
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2018-11-26 23:31:11
Message-ID: 8eee66b181b58f5dd9c0803f94e8d36c () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aacid added inline comments.

INLINE COMMENTS

> colorchecker.py:80
> +						if ipix == -1:
> +							print "%d %x %x %x %x %x" % (ipix, rgbcolor, al0, al, qcolor, c)
> +							sys.exit(1)

Since this is going to cause an exit, can we have a more descriptive message of what is wrong?

REPOSITORY
  R322 KGeography

REVISION DETAIL
  https://phabricator.kde.org/D17110

To: lauranger
Cc: aacid, kde-edu, narvaez, apol

[Attachment #3 (text/html)]

<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; \
font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D17110">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: \
solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px \
8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D17110#inline-93668">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">colorchecker.py:80</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            \
<span style="color: #aa4000">if</span> <span class="n">ipix</span> <span style="color: #aa2211">==</span> \
<span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">:</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">              \
<span style="color: #aa4000">print</span> <span style="color: #766510">&quot;</span><span style="color: \
#bb66bb">%d</span><span style="color: #766510"> </span><span style="color: #bb66bb">%x</span><span \
style="color: #766510"> </span><span style="color: #bb66bb">%x</span><span style="color: #766510"> \
</span><span style="color: #bb66bb">%x</span><span style="color: #766510"> </span><span style="color: \
#bb66bb">%x</span><span style="color: #766510"> </span><span style="color: #bb66bb">%x</span><span \
style="color: #766510">&quot;</span> <span style="color: #aa2211">%</span> <span class="p">(</span><span \
class="n">ipix</span><span class="p">,</span> <span class="n">rgbcolor</span><span class="p">,</span> \
<span class="n">al0</span><span class="p">,</span> <span class="n">al</span><span class="p">,</span> \
<span class="n">qcolor</span><span class="p">,</span> <span class="n">c</span><span class="p">)</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">              \
<span class="n">sys</span><span style="color: #aa2211">.</span><span class="n">exit</span><span \
class="p">(</span><span style="color: #601200">1</span><span class="p">)</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Since this is going to \
cause an exit, can we have a more descriptive message of what is \
wrong?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R322 \
KGeography</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D17110">https://phabricator.kde.org/D17110</a></div></div><br \
/><div><strong>To: </strong>lauranger<br /><strong>Cc: </strong>aacid, kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]