[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D16324: Disable trace mode in KmPlot before deleting tracing curve from the plot
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2018-10-28 22:16:30
Message-ID: ded526d347b3fbf209acefecc2f58c04 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aacid added a comment.


  I think it would make more sense if the logic of the code was on View itself and \
not parser, i.e. parser doesn't care about views, but views care about function it's \
viewing.  
  We already have the
  
    emit functionRemoved( id );
  
  in that function so doing something like
  
  connect(XParser::self(), &Parser::functionRemoved, this, &View::functionRemoved)
  
  and then make the functionRemoved function do something similar to the new code you \
added.  
  At the end "it's the same", but i think it makes more sense from an architectural \
point of view.  
  What do you think?

REPOSITORY
  R334 KmPlot

REVISION DETAIL
  https://phabricator.kde.org/D16324

To: yurchor, #kde_edu
Cc: aacid, kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">aacid added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D16324">View Revision</a></tr></table><br \
/><div><div><p>I think it would make more sense if the logic of the code was on View \
itself and not parser, i.e. parser doesn&#039;t care about views, but views care \
about function it&#039;s viewing.</p>

<p>We already have the</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">emit functionRemoved( id \
);</pre></div>

<p>in that function so doing something like</p>

<p>connect(XParser::self(), &amp;Parser::functionRemoved, this, \
&amp;View::functionRemoved)</p>

<p>and then make the functionRemoved function do something similar to the new code \
you added.</p>

<p>At the end &quot;it&#039;s the same&quot;, but i think it makes more sense from an \
architectural point of view.</p>

<p>What do you think?</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R334 KmPlot</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D16324">https://phabricator.kde.org/D16324</a></div></div><br \
/><div><strong>To: </strong>yurchor, KDE Edu<br /><strong>Cc: </strong>aacid, \
kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]