[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D16182: Port KWordQuiz away from deprecated API and kdelibs4support
From:       Yuri Chornoivan <noreply () phabricator ! kde ! org>
Date:       2018-10-18 5:26:07
Message-ID: a088cca634fb03ec93b162bae8de3624 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

yurchor added a comment.


  In D16182#344997 <https://phabricator.kde.org/D16182#344997>, @aacid wrote:
  
  > Code looks reasonable, i *have not* tried it.
  >
  > So maybe wait for someone to actually give it a second review or if you're \
totally confident you're not breaking stuff just commit it  
  
  Sure. I will wait for two weeks from now then commit the changes if no one objects.

REPOSITORY
  R338 KWordQuiz

REVISION DETAIL
  https://phabricator.kde.org/D16182

To: yurchor, #kde_edu
Cc: aacid, kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">yurchor added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D16182">View Revision</a></tr></table><br \
/><div><div><blockquote style="border-left: 3px solid #8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a \
href="https://phabricator.kde.org/D16182#344997" style="background-color: #e7e7e7;  \
border-color: #e7e7e7;  border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D16182#344997</a>, <a \
href="https://phabricator.kde.org/p/aacid/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@aacid</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Code looks reasonable, i *have not* tried \
it.</p>

<p>So maybe wait for someone to actually give it a second review or if you&#039;re \
totally confident you&#039;re not breaking stuff just commit it</p></div> \
</blockquote>

<p>Sure. I will wait for two weeks from now then commit the changes if no one \
objects.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R338 \
KWordQuiz</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D16182">https://phabricator.kde.org/D16182</a></div></div><br \
/><div><strong>To: </strong>yurchor, KDE Edu<br /><strong>Cc: </strong>aacid, \
kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]