[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D15841: Massive octave session and expression refactoring
From:       Nikita Sirgienko <noreply () phabricator ! kde ! org>
Date:       2018-09-29 21:40:02
Message-ID: 872bed15a55f69b82538c3b0e1c2ffa5 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

sirgienko added inline comments.

INLINE COMMENTS

> octavesession.cpp:313
> +            qDebug() << "subprompt catch";
> +            m_process->write(")]'\"\n");
> +            m_output.clear();

This is not very good solution, but i have no idea, how I exit from octave "user \
input requrested" mode without errors.  Better, if we could write something, that \
finish expression and go in 'line.contains(m_promt)' branch or more usefull error \
(without `)]'"` in end). I also think about `additionInputRequsted` signal, but it's \
not very good solution: we split command in two different input field in this case.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D15841

To: sirgienko, asemke, filipesaraiva
Cc: kde-edu, filipesaraiva, asemke, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">sirgienko added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15841">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15841#inline-85700">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">octavesession.cpp:313</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span class="n">qDebug</span><span class="p">()</span> <span style="color: \
#aa2211">&lt;&lt;</span> <span style="color: #766510">&quot;subprompt \
catch&quot;</span><span class="p">;</span> </div><div style="padding: 0 8px; margin: \
0 4px; background: rgba(151, 234, 151, .6);">            <span \
class="n">m_process</span><span style="color: #aa2211">-&gt;</span><span \
class="n">write</span><span class="p">(</span><span style="color: \
#766510">&quot;)]&#39;</span><span style="color: #bb6622">\&quot;\n</span><span \
style="color: #766510">&quot;</span><span class="p">);</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span class="n">m_output</span><span class="p">.</span><span \
class="n">clear</span><span class="p">();</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
is not very good solution, but i have no idea, how I exit from octave &quot;user \
input requrested&quot; mode without errors. <br /> Better, if we could write \
something, that finish expression and go in &#039;line.contains(m_promt)&#039; branch \
or more usefull error (without <tt style="background: #ebebeb; font-size: \
13px;">)]&#039;&quot;</tt> in end).<br /> I also think about <tt style="background: \
#ebebeb; font-size: 13px;">additionInputRequsted</tt> signal, but it&#039;s not very \
good solution: we split command in two different input field in this \
case.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15841">https://phabricator.kde.org/D15841</a></div></div><br \
/><div><strong>To: </strong>sirgienko, asemke, filipesaraiva<br /><strong>Cc: \
</strong>kde-edu, filipesaraiva, asemke, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]