[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D15865: Use system locale to display numbers in the scheduler.
From:       Eric Dejouhanet <noreply () phabricator ! kde ! org>
Date:       2018-09-30 20:09:22
Message-ID: 7b58c404a83250212bb413a9cf26a296 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

TallFurryMan created this revision.
TallFurryMan added reviewers: mutlaqja, wreissenberger.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  Made XML serialization always use the C locale.
  Displayed numbers based on locale in the job table.
  Updated RA/DEC values in simple_test_no_twilight.esl with my own locale.
  Homogeneized RA/DEC box display - no locale support planned in dmsBox yet.

TEST PLAN
  Load scheduler test vector 'simple_test_no_twilight.esl'.
  Check all target RA/DEC coordinates display properly.
  Edit each target, re-open the object selection panel and re-select the same target.
  Save the scheduler test vector, then re-load the scheduler test vector.
  Without the change, depending on the locale, target coordinates are incorrect and \
only contain the integer part.  With the change, target coordinates are always \
matching their catalog reference.

REPOSITORY
  R321 KStars

BRANCH
  bugfix__decimal_locale_in_scheduler (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15865

AFFECTED FILES
  Tests/scheduler/simple_test_no_twilight.esl
  kstars/ekos/scheduler/scheduler.cpp
  kstars/ekos/scheduler/schedulerjob.cpp

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">TallFurryMan created this revision.<br />TallFurryMan added \
reviewers: mutlaqja, wreissenberger.<br />Herald added a project: KDE Edu.<br \
/>Herald added a subscriber: kde-edu.<br />TallFurryMan requested review of this \
revision. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15865">View Revision</a></tr></table><br \
/><div><strong>REVISION SUMMARY</strong><div><p>Made XML serialization always use the \
C locale.<br /> Displayed numbers based on locale in the job table.<br />
Updated RA/DEC values in simple_test_no_twilight.esl with my own locale.<br />
Homogeneized RA/DEC box display - no locale support planned in dmsBox \
yet.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Load scheduler test \
vector &#039;simple_test_no_twilight.esl&#039;.<br /> Check all target RA/DEC \
coordinates display properly.<br /> Edit each target, re-open the object selection \
panel and re-select the same target.<br /> Save the scheduler test vector, then \
re-load the scheduler test vector.<br /> Without the change, depending on the locale, \
target coordinates are incorrect and only contain the integer part.<br /> With the \
change, target coordinates are always matching their catalog \
reference.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R321 \
KStars</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>bugfix__decimal_locale_in_scheduler (branched \
from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15865">https://phabricator.kde.org/D15865</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>Tests/scheduler/simple_test_no_twilight.esl<br /> \
kstars/ekos/scheduler/scheduler.cpp<br /> \
kstars/ekos/scheduler/schedulerjob.cpp</div></div></div><br /><div><strong>To: \
</strong>TallFurryMan, mutlaqja, wreissenberger<br /><strong>Cc: </strong>kde-edu, \
narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]