[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D15624: Simplify code in the paintEvent
From:       Albert Astals Cid <noreply () phabricator ! kde ! org>
Date:       2018-09-21 22:12:44
Message-ID: 8aeed58e4bede251f7e47794b06e5e93 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Cool looks defenitely easier to understand, please remove the unneded include and commit :)

INLINE COMMENTS

> blinken.cpp:12
>  
> +#include <array>
> +

I guess we don't need this now.

REPOSITORY
  R324 Blinken

BRANCH
  simplifyPaintEvent

REVISION DETAIL
  https://phabricator.kde.org/D15624

To: tcanabrava, aacid
Cc: kde-edu, narvaez, apol

[Attachment #3 (text/html)]

<table><tr><td style="">aacid accepted this revision.<br />aacid added a comment.<br \
/>This revision is now accepted and ready to land. </td><a style="text-decoration: \
none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: \
bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D15624">View \
Revision</a></tr></table><br /><div><div><p>Cool looks defenitely easier to \
understand, please remove the unneded include and commit :)</p></div></div><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15624#inline-84572">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">blinken.cpp:12</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96">#include</span> <span class="cpf">&lt;array&gt;</span><span \
style="color: #304a96"></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I \
guess we don&#039;t need this now.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R324 Blinken</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>simplifyPaintEvent</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15624">https://phabricator.kde.org/D15624</a></div></div><br \
/><div><strong>To: </strong>tcanabrava, aacid<br /><strong>Cc: </strong>kde-edu, \
narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]