[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D15639: Add editorconfig
From: Grzegorz Szymaszek <noreply () phabricator ! kde ! org>
Date: 2018-09-21 19:05:20
Message-ID: 5b2461721b330d69c2e225ccf125c2d8 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
gszymaszek requested changes to this revision.
gszymaszek added inline comments.
INLINE COMMENTS
> .editorconfig:3
> +
> +[*]
> +indent_style = tab
Is there any known `max_line_length`?
> .editorconfig:4-9
> +indent_style = tab
> +indent_size = 4
> +end_of_line = lf
> +charset = utf-8
> +trim_trailing_whitespace = true
> +insert_final_newline = true
Could you sort it?
> .editorconfig:11-21
> +[*.h]
> +indent_style = tab
> +[*.cpp]
> +indent_style = tab
> +
> +[*.txt]
> +indent_size = 4
Not needed IMO.
REPOSITORY
R324 Blinken
REVISION DETAIL
https://phabricator.kde.org/D15639
To: tcanabrava, apol, gszymaszek
Cc: gszymaszek, apol, kde-edu, narvaez
[Attachment #3 (text/html)]
<table><tr><td style="">gszymaszek requested changes to this revision.<br />gszymaszek added inline \
comments. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: \
#464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D15639">View Revision</a></tr></table><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: \
solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px \
8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15639#inline-84552">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">.editorconfig:3</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">[*] \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">indent_style = tab \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is \
there any known <tt style="background: #ebebeb; font-size: \
13px;">max_line_length</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D15639#inline-84548">View Inline</a><span style="color: #4b4d51; \
font-weight: bold;">.editorconfig:4-9</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">indent_style \
= tab </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">indent_size \
= 4 </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">end_of_line = \
lf </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">charset = utf-8
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">trim_trailing_whitespace = true </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">insert_final_newline = true </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Could you sort \
it?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: \
0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: \
0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D15639#inline-84549">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">.editorconfig:11-21</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; \
white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);">[*.h] </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">indent_style = tab </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">[*.cpp] </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">indent_style = tab </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);"> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">[*.txt] </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, \
234, 151, .6);">indent_size = 4 </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Not needed \
IMO.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R324 \
Blinken</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D15639">https://phabricator.kde.org/D15639</a></div></div><br \
/><div><strong>To: </strong>tcanabrava, apol, gszymaszek<br /><strong>Cc: </strong>gszymaszek, apol, \
kde-edu, narvaez<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic