[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D14942: Connect new-image event to Scheduler imaging time estimator.
From:       Jasem Mutlaq <noreply () phabricator ! kde ! org>
Date:       2018-08-31 10:00:57
Message-ID: b500d6e9746dc755faa90462c2846e4a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

mutlaqja added inline comments.

INLINE COMMENTS

> TallFurryMan wrote in ekosmanager.cpp:1805
> I selected the same naming as the lines above the change. Tell me if those were not \
> a proper example.

I think this needs to wait until the new DBus interface is complete. It's in progress \
in dbus_work branch.

REPOSITORY
  R321 KStars

BRANCH
  improve__scheduler_image_update (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14942

To: TallFurryMan, mutlaqja, wreissenberger
Cc: kde-edu, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">mutlaqja added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14942">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14942#inline-79757">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">TallFurryMan</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">ekosmanager.cpp:1805</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">I selected the same naming as the lines above the change. Tell me if those were \
not a proper example.</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">I think this needs to wait until the new DBus \
interface is complete. It&#039;s in progress in dbus_work \
branch.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>improve__scheduler_image_update (branched \
from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14942">https://phabricator.kde.org/D14942</a></div></div><br \
/><div><strong>To: </strong>TallFurryMan, mutlaqja, wreissenberger<br /><strong>Cc: \
</strong>kde-edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]