[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D14523: [import] Update file content overview after file type change
From: Fabian Kristof <noreply () phabricator ! kde ! org>
Date: 2018-07-31 21:17:49
Message-ID: 0a2fddb74ed65ecc690271d3f7423315 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
fkristof added inline comments.
INLINE COMMENTS
> ImportFileWidget.cpp:612
> + // make absolute path // FIXME
> + if ( !fileName.isEmpty() && fileName.at(0) != QDir::separator())
> + return QDir::homePath() + QDir::separator() + fileName;
Remove space
( !fileName.isEmpty()
> ImportFileWidget.cpp:612
> + // make absolute path // FIXME
> + if ( !fileName.isEmpty() && fileName.at(0) != QDir::separator())
> + return QDir::homePath() + QDir::separator() + fileName;
I'd say it would be safer to have 2 separate ifs, even if we know that the order is \
left to right, if somebody changes/adds here something and the fileName.at(0) will be \
before the isEmpty() then there will be a crash.
if (!fileName.isEmpty()) {
if (fileName.at(0) != QDir::separator()) {
> ImportFileWidget.cpp:1106
>
> +void ImportFileWidget::updateContent(const QString& fileName, int fileType)
> +{
AbstractFileFilter::FileType fileType
REPOSITORY
R262 LabPlot
REVISION DETAIL
https://phabricator.kde.org/D14523
To: croick, #labplot
Cc: fkristof, asemke, kde-edu, narvaez, apol
[Attachment #3 (text/html)]
<table><tr><td style="">fkristof added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14523">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14523#inline-76686">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ImportFileWidget.cpp:612</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #74777d">// make absolute path // FIXME</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">if</span> <span class="p">(</span> <span style="color: \
#aa2211">!</span><span class="n">fileName</span><span class="p">.</span><span \
class="n">isEmpty</span><span class="p">()</span> <span style="color: \
#aa2211">&&</span> <span class="n">fileName</span><span \
class="p">.</span><span class="n">at</span><span class="p">(</span><span \
style="color: #601200">0</span><span class="p">)</span> <span style="color: \
#aa2211">!=</span> <span class="n">QDir</span><span style="color: \
#aa2211">::</span><span class="n">separator</span><span class="p">())</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">return</span> <span class="n">QDir</span><span \
style="color: #aa2211">::</span><span class="n">homePath</span><span \
class="p">()</span> <span style="color: #aa2211">+</span> <span \
class="n">QDir</span><span style="color: #aa2211">::</span><span \
class="n">separator</span><span class="p">()</span> <span style="color: \
#aa2211">+</span> <span class="n">fileName</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Remove space</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">( \
!fileName.isEmpty()</pre></div></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14523#inline-76688">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ImportFileWidget.cpp:612</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #74777d">// make absolute path // FIXME</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span \
style="color: #aa4000">if</span> <span class="p">(</span> <span style="color: \
#aa2211">!</span><span class="n">fileName</span><span class="p">.</span><span \
class="n">isEmpty</span><span class="p">()</span> <span style="color: \
#aa2211">&&</span> <span class="n">fileName</span><span \
class="p">.</span><span class="n">at</span><span class="p">(</span><span \
style="color: #601200">0</span><span class="p">)</span> <span style="color: \
#aa2211">!=</span> <span class="n">QDir</span><span style="color: \
#aa2211">::</span><span class="n">separator</span><span class="p">())</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">return</span> <span class="n">QDir</span><span \
style="color: #aa2211">::</span><span class="n">homePath</span><span \
class="p">()</span> <span style="color: #aa2211">+</span> <span \
class="n">QDir</span><span style="color: #aa2211">::</span><span \
class="n">separator</span><span class="p">()</span> <span style="color: \
#aa2211">+</span> <span class="n">fileName</span><span class="p">;</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">I'd say it would be safer to have 2 separate ifs, even if we know \
that the order is left to right, if somebody changes/adds here something and the \
fileName.at(0) will be before the isEmpty() then there will be a crash.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (!fileName.isEmpty()) { if \
(fileName.at(0) != QDir::separator()) {</pre></div>
</div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div \
style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; \
border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; \
padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14523#inline-76708">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">ImportFileWidget.cpp:1106</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"><span style="color: #aa4000">void</span> <span \
class="n">ImportFileWidget</span><span style="color: #aa2211">::</span><span \
class="n">updateContent</span><span class="p">(</span><span style="color: \
#aa4000">const</span> <span class="n">QString</span><span style="color: \
#aa2211">&</span> <span class="n">fileName</span><span class="p">,</span> <span \
style="color: #aa4000">int</span> <span class="n">fileType</span><span \
class="p">)</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"><span class="p">{</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">AbstractFileFilter::FileType fileType</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R262 LabPlot</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14523">https://phabricator.kde.org/D14523</a></div></div><br \
/><div><strong>To: </strong>croick, LabPlot<br /><strong>Cc: </strong>fkristof, \
asemke, kde-edu, narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic