[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D14411: Download and use localization files for KStars Lite
From: Pino Toscano <noreply () phabricator ! kde ! org>
Date: 2018-07-28 8:15:48
Message-ID: b4ee06cc05bc1bace01909d000f6025d () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
pino added inline comments.
INLINE COMMENTS
> catalogdb.cpp:606
> +#else
> errs.append(i18n("Parsing header: ") + i18n("Extra Delimiter field in header: %1."
> " Will be ignored",
Nice, so many string puzzles in this file... will fix them.
> apol wrote in colorscheme.cpp:113
> It's a warning, maybe not really worth translating ever?
Yup, will fix it.
> clientmanagerlite.cpp:242
> {
> + QString temp = QString(i18n("Web Manager Status:"))+' \
> '+i18n("Online"); +
These changes are basically no-nops. Also, more string puzzles to fix...
> LocationEdit.qml:424
> } else {
> - notification.showNotification(xi18n("Added new \
> location - " + fullName)) + \
> notification.showNotification(i18n("Added new location - %1", fullName)) }
This almost looked like a good change... if not for the switch from `xi18n` to \
`i18n`. Anyway, will fix this string puzzle too...
> TimeSpinBox.qml:169
> if ( ! daysOnly ) {
> - timeString.push( "0 " + i18np( "seconds", "secs" ));
> - timeString.push( "0.1 " + i18np( "seconds", "secs" ));
> - timeString.push( "0.25 " + i18np( "seconds", "secs" ));
> - timeString.push( "0.5 " + i18np( "seconds", "secs" ));
> - timeString.push( "1 " + i18np( "second", "sec" ));
> - timeString.push( "2 " + i18np( "seconds", "secs" ));
> - timeString.push( "5 " + i18np( "seconds", "secs" ));
> - timeString.push( "10 " + i18np( "seconds", "secs" ));
> - timeString.push( "20 " + i18np( "seconds", "secs" ));
> - timeString.push( "30 " + i18np( "seconds", "secs" ));
> - timeString.push( "1 " + i18np( "minute", "min" ));
> - timeString.push( "2 " + i18np( "minutes", "mins" ));
> - timeString.push( "5 " + i18np( "minutes", "mins" ));
> - timeString.push( "10 " + i18np( "minutes", "mins" ));
> - timeString.push( "15 " + i18np( "minutes", "mins" ));
> - timeString.push( "30 " + i18np( "minutes", "mins" ));
> - timeString.push( "1 " +xi18n( "hour" ));
> - timeString.push( "2 " + i18np( "hours", "hrs" ));
> - timeString.push( "3 " + i18np( "hours", "hrs" ));
> - timeString.push( "6 " + i18np( "hours", "hrs" ));
> - timeString.push( "12 " + i18np( "hours", "hrs" ));
> + timeString.push( "0 " + xi18n( "seconds" ));
> + timeString.push( "0.1 " + xi18n( "seconds" ));
All the handling of units in the existing QML source is already wrong...
REPOSITORY
R321 KStars
REVISION DETAIL
https://phabricator.kde.org/D14411
To: ckertesz, mutlaqja, pino, apol
Cc: apol, aacid, pino, kde-edu, narvaez
[Attachment #3 (text/html)]
<table><tr><td style="">pino added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D14411">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14411#inline-76064">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">catalogdb.cpp:606</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
style="color: #304a96">#else</span> </div><div style="padding: 0 8px; margin: 0 4px; \
"> <span class="n">errs</span><span class="p">.</span><span \
class="n">append</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span style="color: #766510">"Parsing header: \
"</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span \
class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Extra \
Delimiter field in header: %1."</span> </div><div style="padding: 0 8px; margin: \
0 4px; "> <span \
style="color: #766510">" Will be ignored"</span><span class="p">,</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Nice, so many string puzzles in this file... will fix \
them.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14411#inline-76006">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">apol</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">colorscheme.cpp:113</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">It's a warning, maybe not really worth translating ever?</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Yup, \
will fix it.</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" \
href="https://phabricator.kde.org/D14411#inline-76066">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">clientmanagerlite.cpp:242</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span \
class="n">temp</span> <span style="color: #aa2211">=</span> <span \
class="n">QString</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span style="color: #766510">"Web Manager \
Status:"</span><span class="p">))</span><span style="color: \
#aa2211">+</span><span style="color: #766510">' '</span><span style="color: \
#aa2211">+</span><span class="n">i18n</span><span class="p">(</span><span \
style="color: #766510">"Online"</span><span class="p">);</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">These changes are basically no-nops. Also, more string puzzles to \
fix...</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D14411#inline-76067">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">LocationEdit.qml:424</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> <span class="p">}</span> <span style="color: \
#aa4000">else</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"> \
<span style="color: #004012">notification</span><span class="p">.</span><span \
style="color: #004012">showNotification</span><span class="p">(<span \
class="bright"></span></span><span class="bright"></span><span style="color: \
#004012"><span class="bright">x</span>i18n</span><span class="p">(</span><span \
style="color: #766510">"Added new location - <span \
class="bright">"</span></span><span class="bright"> </span><span style="color: \
#aa2211"><span class="bright">+</span></span> <span style="color: \
#004012">fullName</span><span class="p">))</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #004012">notification</span><span class="p">.</span><span \
style="color: #004012">showNotification</span><span class="p">(</span><span \
style="color: #004012">i18n</span><span class="p">(</span><span style="color: \
#766510">"Added new location - <span class="bright">%1"</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span> <span \
style="color: #004012">fullName</span><span class="p">))</span> </div><div \
style="padding: 0 8px; margin: 0 4px; "> <span \
class="p">}</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This \
almost looked like a good change... if not for the switch from <tt style="background: \
#ebebeb; font-size: 13px;">xi18n</tt> to <tt style="background: #ebebeb; font-size: \
13px;">i18n</tt>. Anyway, will fix this string puzzle too...</p></div></div><br \
/><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D14411#inline-76072">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">TimeSpinBox.qml:169</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: \
#aa4000">if</span> <span class="p">(</span> <span style="color: #aa2211">!</span> \
<span style="color: #004012">daysOnly</span> <span class="p">)</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);"> <span style="color: \
#004012">timeString</span><span class="p">.</span><span style="color: \
#004012">push</span><span class="p">(</span> <span style="color: #766510">"0 \
"</span> <span style="color: #aa2211">+</span> <span style="color: \
#004012">i18n<span class="bright">p</span></span><span class="p">(</span> <span \
style="color: #766510">"second<span class="bright">s"</span></span><span \
class="bright"></span><span class="p"><span class="bright">,</span></span><span \
class="bright"> </span><span style="color: #766510"><span \
class="bright">"sec</span>s"</span> <span class="p">));</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> \
<span style="color: #004012">timeString</span><span class="p">.</span><span \
style="color: #004012">push</span><span class="p">(</span> <span style="color: \
#766510">"0.1 "</span> <span style="color: #aa2211">+</span> <span \
style="color: #004012">i18n<span class="bright">p</span></span><span \
class="p">(</span> <span style="color: #766510">"second<span \
class="bright">s"</span></span><span class="bright"></span><span class="p"><span \
class="bright">,</span></span><span class="bright"> </span><span style="color: \
#766510"><span class="bright">"sec</span>s"</span> <span \
class="p">));</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: \
#004012">timeString</span><span class="p">.</span><span style="color: \
#004012">push</span><span class="p">(</span> <span style="color: #766510">"0 \
"</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span \
style="color: #004012"><span class="bright">x</span>i18n</span><span \
class="p">(</span> <span style="color: #766510">"seconds"</span> <span \
class="p">));</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: \
#004012">timeString</span><span class="p">.</span><span style="color: \
#004012">push</span><span class="p">(</span> <span style="color: #766510">"0.1 \
"</span> <span style="color: #aa2211">+</span> <span class="bright"></span><span \
style="color: #004012"><span class="bright">x</span>i18n</span><span \
class="p">(</span> <span style="color: #766510">"seconds"</span> <span \
class="p">));</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">All \
the handling of units in the existing QML source is already \
wrong...</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R321 KStars</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14411">https://phabricator.kde.org/D14411</a></div></div><br \
/><div><strong>To: </strong>ckertesz, mutlaqja, pino, apol<br /><strong>Cc: \
</strong>apol, aacid, pino, kde-edu, narvaez<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic