[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D13675: Fix sage backend for Sage 8.1 and 8.2
From:       Luca Beltrame <noreply () phabricator ! kde ! org>
Date:       2018-06-27 21:13:01
Message-ID: 932e97cb9ccbef597bfe173a479d1485 () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

lbeltrame added inline comments.

INLINE COMMENTS

> sirgienko wrote in CMakeLists.txt:35
> And with "rwxr-xr-x" all works fine?

No. This line was not correct, you had to use INSTALL(PROGRAMS...) and not \
INSTALL(FILES..). Either way, it's fixed in bcc16ae0d7d9aa08dcd77e31b7204b758f5c117c \
<https://phabricator.kde.org/R55:bcc16ae0d7d9aa08dcd77e31b7204b758f5c117c> (not by \
me).

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D13675

To: sirgienko, asemke
Cc: lbeltrame, kde-edu, asemke, narvaez, apol


[Attachment #3 (text/html)]

<table><tr><td style="">lbeltrame added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13675">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13675#inline-72337">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">sirgienko</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:35</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">And with &quot;rwxr-xr-x&quot; all works fine?</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">No. This \
line was not correct, you had to use INSTALL(PROGRAMS...) and not INSTALL(FILES..). \
Either way, it&#039;s fixed in <a \
href="https://phabricator.kde.org/R55:bcc16ae0d7d9aa08dcd77e31b7204b758f5c117c" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: \
none;">bcc16ae0d7d9aa08dcd77e31b7204b758f5c117c</a> (not by \
me).</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13675">https://phabricator.kde.org/D13675</a></div></div><br \
/><div><strong>To: </strong>sirgienko, asemke<br /><strong>Cc: </strong>lbeltrame, \
kde-edu, asemke, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]