[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D13088: piano_composition, add replace and edit features.
From:       Aman Kumar Gupta <noreply () phabricator ! kde ! org>
Date:       2018-05-26 10:07:37
Message-ID: 20180526100737.1.468ED88AD45F96CE () phabricator ! kde ! org
[Download RAW message or body]

amankumargupta marked 4 inline comments as done.
amankumargupta added inline comments.

INLINE COMMENTS

> jjazeix wrote in Note.qml:62
> why 6 is hardcoded?

because the notes whose position are more than 6 on the staff will have ledger lines \
and in that case the whole note image has to be inverted.

However I've added a readonly property variable for this to make it easy to \
understand for anyone reading the code.

> jjazeix wrote in Note.qml:119
> why -6, can you create a readonly property for it?

-6 is the returned value denoting invalid condition. Since the numbers upto -5 are \
already occupied, I chose -6 to be the invalid case number.

Sure, will create a readonly property for it.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D13088

To: amankumargupta, #gcompris_activities, jjazeix
Cc: jjazeix, kde-edu, #gcompris_activities, himanshuvishwakarma, harrymecwan, \
ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, \
timotheegiet, hkaelberer, bcoudoin


[Attachment #3 (unknown)]

<table><tr><td style="">amankumargupta marked 4 inline comments as done.<br \
/>amankumargupta added inline comments. </td><a style="text-decoration: none; \
padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; \
border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13088">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13088#inline-67934">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">Note.qml:62</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">why 6 is hardcoded?</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">because the notes whose position are more \
than 6 on the staff will have ledger lines and in that case the whole note image has \
to be inverted.</p>

<p style="padding: 0; margin: 8px;">However I&#039;ve added a readonly property \
variable for this to make it easy to understand for anyone reading the \
code.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D13088#inline-67937">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in \
<span style="color: #4b4d51; font-weight: bold;">Note.qml:119</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">why -6, can you create a readonly property for it?</p></div></div> <div \
style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">-6 is the \
returned value denoting invalid condition. Since the numbers upto -5 are already \
occupied, I chose -6 to be the invalid case number.</p>

<p style="padding: 0; margin: 8px;">Sure, will create a readonly property for \
it.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13088">https://phabricator.kde.org/D13088</a></div></div><br \
/><div><strong>To: </strong>amankumargupta, GCompris: Activities, jjazeix<br \
/><strong>Cc: </strong>jjazeix, kde-edu, GCompris: Activities, himanshuvishwakarma, \
harrymecwan, ganeshredcobra, nityanandkumar, echarruau, rahulyadav, narvaez, \
scagarwal, apol, timotheegiet, hkaelberer, bcoudoin<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]