[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D12504: Fix problem with first entry for scilab backend
From:       Nikita Sirgienko <noreply () phabricator ! kde ! org>
Date:       2018-04-24 20:03:12
Message-ID: 20180424200312.1.238C0707F91D245F () phabricator ! kde ! org
[Download RAW message or body]

sirgienko created this revision.
sirgienko added reviewers: Cantor, asemke.
sirgienko added a project: Cantor.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.
sirgienko requested review of this revision.

REVISION SUMMARY
  Now scilab backend start update keywords for highlighter in login function and with \
new login mechanism computation of first runned entry never ends. So this patch fix \
it by moving  highlighting functionality to the scilab highlighter and adding \
expression queue in backend.

TEST PLAN
  1. Start scilab session and try run something
  2. Check, that runned expression never ends
  3. Apply the patch
  4. Do 1)-2) and check, that now all fine.

REPOSITORY
  R55 Cantor

BRANCH
  fix-scilab

REVISION DETAIL
  https://phabricator.kde.org/D12504

AFFECTED FILES
  src/backends/scilab/scilabhighlighter.cpp
  src/backends/scilab/scilabhighlighter.h
  src/backends/scilab/scilabsession.cpp
  src/backends/scilab/scilabsession.h

To: sirgienko, #cantor, asemke
Cc: #cantor, #kde_edu, narvaez, apol


[Attachment #3 (unknown)]

<table><tr><td style="">sirgienko created this revision.<br />sirgienko added \
reviewers: Cantor, asemke.<br />sirgienko added a project: Cantor.<br />Restricted \
Application added a subscriber: KDE Edu.<br />Restricted Application added a project: \
KDE Edu.<br />sirgienko requested review of this revision. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12504">View \
Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Now \
scilab backend start update keywords for highlighter in login function and with new \
login mechanism computation of first runned entry never ends. So this patch fix it by \
moving  highlighting functionality to the scilab highlighter and adding expression \
queue in backend.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ol \
class="remarkup-list"> <li class="remarkup-list-item">Start scilab session and try \
run something</li> <li class="remarkup-list-item">Check, that runned expression never \
ends</li> <li class="remarkup-list-item">Apply the patch</li>
<li class="remarkup-list-item">Do 1)-2) and check, that now all fine.</li>
</ol></div></div><br /><div><strong>REPOSITORY</strong><div><div>R55 \
Cantor</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>fix-scilab</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12504">https://phabricator.kde.org/D12504</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/backends/scilab/scilabhighlighter.cpp<br /> \
src/backends/scilab/scilabhighlighter.h<br /> \
src/backends/scilab/scilabsession.cpp<br /> \
src/backends/scilab/scilabsession.h</div></div></div><br /><div><strong>To: \
</strong>sirgienko, Cantor, asemke<br /><strong>Cc: </strong>Cantor, KDE Edu, \
narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]