[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D12310: Keyboard control support [T8492]
From:       Aman Kumar Gupta <noreply () phabricator ! kde ! org>
Date:       2018-04-18 19:14:36
Message-ID: 20180418191436.1.A0F84DFF93ECF4D5 () phabricator ! kde ! org
[Download RAW message or body]

amankumargupta added inline comments.

INLINE COMMENTS

> Lightsoff.qml:204
> 
> -                    BarButton {
> -                        anchors.fill: parent
> -                        fillMode: Image.PreserveAspectFit
> -                        source: Activity.url + "off.svg"
> -                        opacity: lighton === 1 ? 0 : 1
> -                        z: lighton === 1 ? 10 : 11
> -                        sourceSize.height: items.cellSize
> -                        onClicked: {
> -                            \
>                 activity.audioEffects.play('qrc:/gcompris/src/core/resource/sounds/scroll.wav')
>                 
> -                            Activity.switchLight(index)
> +                BarButton {
> +                    anchors.fill: parent

Can these two BarButton be refactored into one?

REVISION DETAIL
  https://phabricator.kde.org/D12310

To: harrymecwan, #gcompris_improvements
Cc: amankumargupta, #kde_edu, himanshuvishwakarma, harrymecwan, ganeshredcobra, \
nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, \
hkaelberer, jjazeix, bcoudoin


[Attachment #3 (unknown)]

<table><tr><td style="">amankumargupta added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12310">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12310#inline-62397">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Lightsoff.qml:204</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">          \
<span class="bright">    </span><span style="color: #004012">BarButton</span> <span \
class="p">{</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">                    <span class="bright">    </span><span \
style="color: #aa4000">anchors.fill:</span> <span style="color: \
#004012">parent</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);">                <span style="color: \
#004012">BarButton</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span \
style="color: #aa4000">anchors.fill:</span> <span style="color: \
#004012">parent</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can \
these two BarButton be refactored into one?</p></div></div></div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12310">https://phabricator.kde.org/D12310</a></div></div><br \
/><div><strong>To: </strong>harrymecwan, GCompris: Improvements<br /><strong>Cc: \
</strong>amankumargupta, KDE Edu, himanshuvishwakarma, harrymecwan, ganeshredcobra, \
nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, \
hkaelberer, jjazeix, bcoudoin<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]