[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D12190: Make clients select password
From: Johnny Jazeix <noreply () phabricator ! kde ! org>
Date: 2018-04-16 11:02:30
Message-ID: 20180416110230.1.BA287F74BD8896D1 () phabricator ! kde ! org
[Download RAW message or body]
jjazeix added inline comments.
INLINE COMMENTS
> main.qml:361
> chooseLogin.model = logins;
> + choosePassword.model = passwords;
> chooseLogin.visible = true
If there are images, I would display all the potential images for passwords, not just \
the one from the group. If there are only 2 children in the group, you will only have \
the 2 images displayed and each child will know the other child password.
> main.qml:437
> + property var model
> + content: ListView {
> + id: view
Either the child is old enough to type his password, we don't provide a list of all \
passwords and he has to type. Or for younger children, we can display it as a Grid of \
images with a OK/Cancel button and the child has to select the good image and click \
on OK.
> main.qml:461
> + ExclusiveGroup {
> + id: exclusiveGroupItem_2
> + onCurrentChanged: { if(current) choosePassword.chosenPassword = \
> current.text; }
can there be a better name than _2?
REPOSITORY
R2 GCompris
REVISION DETAIL
https://phabricator.kde.org/D12190
To: rishabhg, jjazeix, timotheegiet
Cc: #kde_edu, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, \
echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, \
bcoudoin
[Attachment #3 (unknown)]
<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12190">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12190#inline-61846">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.qml:361</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: \
#004012">chooseLogin</span><span class="p">.</span><span style="color: \
#004012">model</span> <span style="color: #aa2211">=</span> <span style="color: \
#004012">logins</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#004012">choosePassword</span><span class="p">.</span><span style="color: \
#004012">model</span> <span style="color: #aa2211">=</span> <span style="color: \
#004012">passwords</span><span class="p">;</span> </div><div style="padding: 0 8px; \
margin: 0 4px; "> <span style="color: #004012">chooseLogin</span><span \
class="p">.</span><span style="color: #004012">visible</span> <span style="color: \
#aa2211">=</span> <span style="color: #000a65">true</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">If \
there are images, I would display all the potential images for passwords, not just \
the one from the group.<br /> If there are only 2 children in the group, you will \
only have the 2 images displayed and each child will know the other child \
password.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D12190#inline-61849">View \
Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:437</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"> <span style="color: #004012">property</span> <span style="color: \
#aa4000">var</span> <span style="color: #004012">model</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #aa4000">content:</span> <span style="color: \
#004012">ListView</span> <span class="p">{</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: \
#aa4000">id: view</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Either the child is old enough to type his password, we don't provide a \
list of all passwords and he has to type.<br /> Or for younger children, we can \
display it as a Grid of images with a OK/Cancel button and the child has to select \
the good image and click on OK.</p></div></div><br /><div style="border: 1px solid \
#C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D12190#inline-61517">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">main.qml:461</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
<span style="color: #004012">ExclusiveGroup</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">id: exclusiveGroupItem_2</span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"> <span style="color: #aa4000">onCurrentChanged:</span> <span \
class="p">{</span> <span style="color: #aa4000">if</span><span \
class="p">(</span><span style="color: #004012">current</span><span class="p">)</span> \
<span style="color: #004012">choosePassword</span><span class="p">.</span><span \
style="color: #004012">chosenPassword</span> <span style="color: #aa2211">=</span> \
<span style="color: #004012">current</span><span class="p">.</span><span \
style="color: #004012">text</span><span class="p">;</span> <span class="p">}</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">can there be a better name than \
_2?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12190">https://phabricator.kde.org/D12190</a></div></div><br \
/><div><strong>To: </strong>rishabhg, jjazeix, timotheegiet<br /><strong>Cc: \
</strong>KDE Edu, himanshuvishwakarma, harrymecwan, ganeshredcobra, nityanandkumar, \
echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, \
bcoudoin<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic