[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D11626: Fix problems with repetitive addition of function `cantor_print ()` in worksheet
From:       Nikita Sirgienko <noreply () phabricator ! kde ! org>
Date:       2018-03-23 21:11:41
Message-ID: 20180323211141.1.923EFAB92C214689 () phabricator ! kde ! org
[Download RAW message or body]

sirgienko created this revision.
sirgienko added a reviewer: Cantor.
sirgienko added a project: Cantor.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.
sirgienko requested review of this revision.

REVISION SUMMARY
  Octave use special script for plots, that is added for each entry with octave plot commands. \
Unfortunately, this command is add to entry when expressions in worksheet are saving (maybe should add \
virtual method `toSaveString()` to `Cantor::Expression`?). So, I have added addition check, if this \
command already exist in entry, to avoid the multiple addition of this command to entries each time, when \
worksheet save and load.

TEST PLAN
  1. Create worksheet and write some commands to print plots
  2. Save and load this worksheet
  3. Do 2) again few times
  4. Verify,that `cantor_print()` function appears no more than once in each entry.

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D11626

AFFECTED FILES
  src/backends/octave/octaveexpression.cpp

To: sirgienko, #cantor
Cc: #cantor, #kde_edu, narvaez, apol


[Attachment #3 (unknown)]

<table><tr><td style="">sirgienko created this revision.<br />sirgienko added a reviewer: Cantor.<br \
/>sirgienko added a project: Cantor.<br />Restricted Application added a subscriber: KDE Edu.<br \
/>Restricted Application added a project: KDE Edu.<br />sirgienko requested review of this revision. \
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; \
font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11626">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Octave use special script for plots, that is added for each entry with octave \
plot commands. Unfortunately, this command is add to entry when expressions in worksheet are saving \
(maybe should add virtual method <tt style="background: #ebebeb; font-size: 13px;">toSaveString()</tt> to \
<tt style="background: #ebebeb; font-size: 13px;">Cantor::Expression</tt>?). So, I have added addition \
check, if this command already exist in entry, to avoid the multiple addition of this command to entries \
each time, when worksheet save and load.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ol \
class="remarkup-list"> <li class="remarkup-list-item">Create worksheet and write some commands to print \
plots</li> <li class="remarkup-list-item">Save and load this worksheet</li>
<li class="remarkup-list-item">Do 2) again few times</li>
<li class="remarkup-list-item">Verify,that <tt style="background: #ebebeb; font-size: \
13px;">cantor_print()</tt> function appears no more than once in each entry.</li> </ol></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R55 Cantor</div></div></div><br /><div><strong>REVISION \
DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11626">https://phabricator.kde.org/D11626</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/backends/octave/octaveexpression.cpp</div></div></div><br /><div><strong>To: \
</strong>sirgienko, Cantor<br /><strong>Cc: </strong>Cantor, KDE Edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]