[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D11485: Add readonly properties to AnswerButton.qml to check whether correct and wrong answer animat
From:       Aman Kumar Gupta <noreply () phabricator ! kde ! org>
Date:       2018-03-20 9:23:27
Message-ID: 20180320092327.1.DE6E16D5774D47B8 () phabricator ! kde ! org
[Download RAW message or body]

amankumargupta added inline comments.

INLINE COMMENTS

> jjazeix wrote in AnswerButton.qml:42
> why don't you directly put blockClicks: correctAnswerAnimation.running || \
> wrongAnswerAnimation.running and remove the assignment in correctAnswerAnimation?

Yes, this can be a solution and we can make it default.

But there may be some other situations in some activities during which we also would \
want to block buttons, along with the duration when animation is running, so these \
variables can come in handy for them when the activity needs to redefine blockClicks \
externally ?

Like, in Solar System activity, we also need to block it when the closeness meter \
animation is running. Maybe there can be similar needs for activities in the future.

Example: in the activity -->** blockClicks: isCorrectAnswerAnimationRunning || \
isWrongAnswerAnimationRunning || someOtherConditionsInTheActivity**

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D11485

To: amankumargupta, #gcompris_improvements
Cc: jjazeix, #kde_edu, #gcompris_improvements, narvaez, apol


[Attachment #3 (unknown)]

<table><tr><td style="">amankumargupta added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D11485">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D11485#inline-56707">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">jjazeix</span> wrote in <span \
style="color: #4b4d51; font-weight: bold;">AnswerButton.qml:42</span></div> <div \
style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: \
8px;">why don&#039;t you directly put blockClicks: correctAnswerAnimation.running || \
wrongAnswerAnimation.running<br /> and remove the assignment in \
correctAnswerAnimation?</p></div></div> <div style="margin: 8px 0; padding: 0 \
12px;"><p style="padding: 0; margin: 8px;">Yes, this can be a solution and we can \
make it default.</p>

<p style="padding: 0; margin: 8px;">But there may be some other situations in some \
activities during which we also would want to block buttons, along with the duration \
when animation is running, so these variables can come in handy for them when the \
activity needs to redefine blockClicks externally ?</p>

<p style="padding: 0; margin: 8px;">Like, in Solar System activity, we also need to \
block it when the closeness meter animation is running.<br /> Maybe there can be \
similar needs for activities in the future.</p>

<p style="padding: 0; margin: 8px;">Example: in the activity --&gt;<strong> \
blockClicks: isCorrectAnswerAnimationRunning || isWrongAnswerAnimationRunning || \
someOtherConditionsInTheActivity</strong></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D11485">https://phabricator.kde.org/D11485</a></div></div><br \
/><div><strong>To: </strong>amankumargupta, GCompris: Improvements<br /><strong>Cc: \
</strong>jjazeix, KDE Edu, GCompris: Improvements, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]