[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D9475: submarine: Fix Vanne animations not working from keyboard controls
From:       Johnny Jazeix <noreply () phabricator ! kde ! org>
Date:       2018-01-12 14:05:08
Message-ID: 20180112140508.1.EEB74581651054F1 () phabricator ! kde ! org
[Download RAW message or body]

jjazeix added inline comments.

INLINE COMMENTS

> Controls.qml:43
>  
>      property alias centralTankVisible : centralBallastTankController.visible
>      property point centralBallastTankPosition

all of these information are the same for the 3 ballasts. Is there a way to factorise it too?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9475

To: rudranilbasu, jjazeix, timotheegiet
Cc: #kde_edu, narvaez, apol

[Attachment #3 (unknown)]

<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: \
#464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: \
linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid \
rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9475" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: \
6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: \
0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; \
margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: \
hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D9475#inline-42946" rel="noreferrer">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">Controls.qml:43</span></div> <div style="font: \
11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
">    <span style="color: #004012">property</span> <span style="color: #004012">alias</span> \
<span style="color: #aa4000">centralTankVisible :</span> <span style="color: \
#004012">centralBallastTankController</span><span class="p">.</span><span style="color: \
#004012">visible</span> </div><div style="padding: 0 8px; margin: 0 4px; ">    <span \
style="color: #004012">property</span> <span style="color: #004012">point</span> <span \
style="color: #004012">centralBallastTankPosition</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">all of these \
information are the same for the 3 ballasts. Is there a way to factorise it \
too?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R2 \
GCompris</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9475" \
rel="noreferrer">https://phabricator.kde.org/D9475</a></div></div><br /><div><strong>To: \
</strong>rudranilbasu, jjazeix, timotheegiet<br /><strong>Cc: </strong>KDE Edu, narvaez, \
apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]