[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D9360: Adding feature to change letters to capital and back (Ref: T5936)
From:       Johnny Jazeix <noreply () phabricator ! kde ! org>
Date:       2017-12-29 17:44:04
Message-ID: 20171229174404.1.F3149F45F3DD0BFA () phabricator ! kde ! org
[Download RAW message or body]

jjazeix added inline comments.

INLINE COMMENTS

> LetterInWord.qml:69
> property alias wordsModel: wordsModel
> +            property int currentLetterCase: 0
> +            property var letterCase: [

why don't you directly use the string value (not the text displayed, but a value \
associated to the combobox text)? It will be more explicit when used than the index

> LetterInWord.qml:70
> +            property int currentLetterCase: 0
> +            property var letterCase: [
> +                {"text": qsTr("Lower Case")},

as it is only used in the combobox (and not in the js file), it is better to declare \
it in the combobox

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9360

To: rohitdas, #gcompris, #gcompris_improvements, jjazeix
Cc: jjazeix, #kde_edu, narvaez, apol


[Attachment #3 (unknown)]

<table><tr><td style="">jjazeix added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D9360" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D9360#inline-43222" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">LetterInWord.qml:69</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; ">            <span style="color: #004012">property</span> <span \
style="color: #004012">alias</span> <span style="color: #aa4000">wordsModel:</span> \
<span style="color: #004012">wordsModel</span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: \
#004012">property</span> <span style="color: #304a96">int</span> <span style="color: \
#aa4000">currentLetterCase:</span> <span style="color: #601200">0</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #004012">property</span> <span style="color: #aa4000">var</span> \
<span style="color: #aa4000">letterCase:</span> <span class="p">[</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">why don&#039;t you directly use the string value (not the text \
displayed, but a value associated to the combobox text)? It will be more explicit \
when used than the index</p></div></div><br /><div style="border: 1px solid #C7CCD9; \
border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: \
#e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: \
#74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: \
right; text-decoration: none;" href="https://phabricator.kde.org/D9360#inline-43223" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">LetterInWord.qml:70</span></div> <div style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: \
#004012">property</span> <span style="color: #304a96">int</span> <span style="color: \
#aa4000">currentLetterCase:</span> <span style="color: #601200">0</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span style="color: #004012">property</span> <span style="color: #aa4000">var</span> \
<span style="color: #aa4000">letterCase:</span> <span class="p">[</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          \
<span class="p">{</span><span style="color: #766510">&quot;text&quot;</span><span \
style="color: #aa2211">:</span> <span style="color: #004012">qsTr</span><span \
class="p">(</span><span style="color: #766510">&quot;Lower Case&quot;</span><span \
class="p">)},</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">as \
it is only used in the combobox (and not in the js file), it is better to declare it \
in the combobox</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9360" \
rel="noreferrer">https://phabricator.kde.org/D9360</a></div></div><br \
/><div><strong>To: </strong>rohitdas, GCompris, GCompris: Improvements, jjazeix<br \
/><strong>Cc: </strong>jjazeix, KDE Edu, narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]