[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D698: Port from WebKit to WebEngine.
From: Anthony Fieroni <noreply () phabricator ! kde ! org>
Date: 2017-12-29 6:13:09
Message-ID: 20171229061309.1.9450086D1F8520DD () phabricator ! kde ! org
[Download RAW message or body]
anthonyfieroni added inline comments.
INLINE COMMENTS
> CMakeLists.txt:29-30
> +
> ${Qt5WebKitWidgets_LIBRARIES}
> ${Qt5WebKit_LIBRARIES}
> ${Qt5Sql_LIBRARIES}
You now depends on 2 engines, WebEngine and Webkit. So to be port complete remove \
Webkit or make it optional (last one will introduce many compile time conditional \
code) Situation is the same for other executables.
> MarbleLegendBrowser.cpp:86-88
> +//TODO: no easy way to delegate links
> +// page()->setLinkDelegationPolicy( QWebEnginePage::DelegateAllLinks );
> +// connect( this, SIGNAL(linkClicked(QUrl)), this, \
> SLOT(openLinkExternally(QUrl)) );
Docs <https://doc.qt.io/qt-5/qtwebenginewidgets-qtwebkitportingguide.html> says it \
will be overridden QWebEnginePage::acceptNavigationRequest
> MarbleLegendBrowser.cpp:398
> +//TODO: No api to support extracting DOM elements.
> +// QWebElement box = \
> page()->mainFrame()->findFirstElement("input[name="+name+']'); +// if \
> (!box.isNull()) {
http://doc.qt.io/archives/qt-5.5/qwebframe.html#findFirstElement ?
> PopupItem.cpp:400
> +
> +//TODO: No api for printing the web page.
> +// QPrinter printer;
It has https://doc.qt.io/qt-5/qwebenginepage.html#print
REPOSITORY
R34 Marble
REVISION DETAIL
https://phabricator.kde.org/D698
To: cmihalache, #marble
Cc: anthonyfieroni, mnafees, #kde_edu, kossebau, rahn, nienhueser, #marble, jalvarez, \
tjakobi, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, marble-devel
[Attachment #3 (unknown)]
<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D698" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D698#inline-43178" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">CMakeLists.txt:29-30</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; "> ${Qt5WebKitWidgets_LIBRARIES} </div><div style="padding: 0 \
8px; margin: 0 4px; "> ${Qt5WebKit_LIBRARIES} </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You \
now depends on 2 engines, WebEngine and Webkit. So to be port complete remove Webkit \
or make it optional (last one will introduce many compile time conditional code) \
Situation is the same for other executables.</p></div></div><br /><div style="border: \
1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D698#inline-43180" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">MarbleLegendBrowser.cpp:86-88</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: \
#74777d">//TODO: no easy way to delegate links</span> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: \
#74777d">// page()->setLinkDelegationPolicy( QWebEnginePage::DelegateAllLinks \
);</span> </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, \
151, .6);"><span style="color: #74777d">// connect( this, \
SIGNAL(linkClicked(QUrl)), this, SLOT(openLinkExternally(QUrl)) );</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;"><a href="https://doc.qt.io/qt-5/qtwebenginewidgets-qtwebkitportingguide.html" \
class="remarkup-link" target="_blank" rel="noreferrer">Docs</a> says it will be \
overridden QWebEnginePage::acceptNavigationRequest</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D698#inline-43181" rel="noreferrer">View \
Inline</a><span style="color: #4b4d51; font-weight: \
bold;">MarbleLegendBrowser.cpp:398</span></div> <div style="font: 11px/15px \
"Menlo", "Consolas", "Monaco", monospace; white-space: \
pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> \
</span><span class="n"><span class="bright">update</span></span><span \
class="bright"></span><span class="p"><span class="bright">();</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span class="bright"></span><span style="color: #74777d"><span \
class="bright">//TODO: No api to support extracting DOM elements.</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span style="color: #74777d">// QWebElement box = \
page()->mainFrame()->findFirstElement("input[name="+name+']');</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);"><span style="color: #74777d">// if (!box.isNull()) {</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;"><a href="http://doc.qt.io/archives/qt-5.5/qwebframe.html#findFirstElement" \
class="remarkup-link" target="_blank" \
rel="noreferrer">http://doc.qt.io/archives/qt-5.5/qwebframe.html#findFirstElement</a> \
?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D698#inline-43182" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">PopupItem.cpp:400</span></div> <div style="font: 11px/15px "Menlo", \
"Consolas", "Monaco", monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span \
class="n"><span class="bright">QPrinter</span></span><span class="bright"> \
</span><span class="n"><span class="bright">printer</span></span><span \
class="bright"></span><span class="p"><span class="bright">;</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span \
class="bright"> </span><span class="n"><span \
class="bright">QPointer</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright"><</span></span><span class="bright"></span><span \
class="n"><span class="bright">QP</span>rint<span \
class="bright">Dialog</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">></span></span><span class="bright"> </span><span \
class="n"><span class="bright">dialog</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> \
</span><span style="color: #aa4000"><span class="bright">new</span></span><span \
class="bright"> </span><span class="n"><span \
class="bright">QPrintDialog</span></span><span class="bright"></span><span \
class="p"><span class="bright">(</span></span><span class="bright"></span><span \
style="color: #aa2211"><span class="bright">&</span></span><span \
class="bright"></span><span class="n"><span class="bright">printer</span></span><span \
class="bright"></span><span class="p"><span class="bright">);</span></span> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);"> <span class="bright"></span><span style="color: #aa4000"><span \
class="bright">if</span></span><span class="bright"> </span><span class="p"><span \
class="bright">(</span></span><span class="bright"></span><span class="n"><span \
class="bright">dialog</span></span><span class="bright"></span><span style="color: \
#aa2211"><span class="bright">-></span></span><span class="bright"></span><span \
class="n"><span class="bright">exec</span></span><span class="bright"></span><span \
class="p"><span class="bright">()</span></span><span class="bright"> </span><span \
style="color: #aa2211"><span class="bright">==</span></span><span class="bright"> \
</span><span class="n">QPrint<span class="bright">Dialog</span></span><span \
class="bright"></span><span style="color: #aa2211"><span \
class="bright">::</span></span><span class="bright"></span><span class="n"><span \
class="bright">Accepted</span></span><span class="bright"></span><span \
class="p"><span class="bright">)</span></span><span class="bright"> </span><span \
class="p"><span class="bright">{</span></span> </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(151, 234, 151, .6);"> </div><div style="padding: 0 \
8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="bright"></span><span style="color: #74777d"><span class="bright">//TODO: No \
api for p</span>rint<span class="bright">ing the web page.</span></span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span \
class="bright"></span><span style="color: #74777d"><span class="bright">//</span> \
QPrint<span class="bright">er printer;</span></span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It \
has <a href="https://doc.qt.io/qt-5/qwebenginepage.html#print" class="remarkup-link" \
target="_blank" rel="noreferrer">https://doc.qt.io/qt-5/qwebenginepage.html#print</a></p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R34 Marble</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D698" \
rel="noreferrer">https://phabricator.kde.org/D698</a></div></div><br \
/><div><strong>To: </strong>cmihalache, Marble<br /><strong>Cc: \
</strong>anthonyfieroni, mnafees, KDE Edu, kossebau, rahn, nienhueser, Marble, \
jalvarez, tjakobi, shentey, chaz6, dkolozsvari, narvaez, cmihalache, apol, \
marble-devel<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic