[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D9475: submarine: Fix Vanne animations not working from keyboard controls
From:       Rudra Nil Basu <noreply () phabricator ! kde ! org>
Date:       2017-12-22 10:37:58
Message-ID: differential-rev-PHID-DREV-2yiqq77ahr4265nfwfcm-req () phabricator ! kde ! org
[Download RAW message or body]

rudranilbasu created this revision.
rudranilbasu added reviewers: jjazeix, timotheegiet.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.

REVISION SUMMARY
  Since most of the Animation Components attached to each of the Vannes of the
  Ballast tanks do the same function, it is replaced with two functions ballastTankOnAnim
  and ballastTankOffAnim, which is called via the updateVannes() function.
  
  The updateVannes() function is also called from Submarine.qml, to fix the error of
  the animations not being called via the keyboard controls.
  
  Also fixed Vannes' state not updating on level changes by adding a reset() method
  which sets the angle of the visible Vannes to zero
  
    rotateLeftFill.angle = 0
    rotateLeftFlush.angle = 0
    
    rotateCentralFill.angle = 0
    rotateCentralFlush.angle = 0
    
    rotateRightFill.angle = 0
    rotateRightFlush.angle = 0

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D9475

AFFECTED FILES
  src/activities/submarine/Controls.qml
  src/activities/submarine/Submarine.qml
  src/activities/submarine/submarine.js

To: rudranilbasu, jjazeix, timotheegiet
Cc: #kde_edu, narvaez, apol

[Attachment #3 (unknown)]

<table><tr><td style="">rudranilbasu created this revision.<br />rudranilbasu added \
reviewers: jjazeix, timotheegiet.<br />Restricted Application added a subscriber: KDE \
Edu.<br />Restricted Application added a project: KDE Edu. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9475" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Since most of the Animation Components attached to each of \
the Vannes of the<br /> Ballast tanks do the same function, it is replaced with two \
functions ballastTankOnAnim<br /> and ballastTankOffAnim, which is called via the \
updateVannes() function.</p>

<p>The updateVannes() function is also called from Submarine.qml, to fix the error \
of<br /> the animations not being called via the keyboard controls.</p>

<p>Also fixed Vannes&#039; state not updating on level changes by adding a reset() \
method<br /> which sets the angle of the visible Vannes to zero</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" \
data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px \
&quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, monospace; padding: \
12px; margin: 0; background: rgba(71, 87, 120, 0.08);">rotateLeftFill.angle = 0 \
rotateLeftFlush.angle = 0

rotateCentralFill.angle = 0
rotateCentralFlush.angle = 0

rotateRightFill.angle = 0
rotateRightFlush.angle = 0</pre></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9475" \
rel="noreferrer">https://phabricator.kde.org/D9475</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/activities/submarine/Controls.qml<br /> \
src/activities/submarine/Submarine.qml<br /> \
src/activities/submarine/submarine.js</div></div></div><br /><div><strong>To: \
</strong>rudranilbasu, jjazeix, timotheegiet<br /><strong>Cc: </strong>KDE Edu, \
narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]