[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: D9395: Configuration capabilities for online dictionaries
From: Dimitris Kardarakos <noreply () phabricator ! kde ! org>
Date: 2017-12-18 12:41:44
Message-ID: differential-rev-PHID-DREV-lhsv6kxfesbyn75ys7ip-req () phabricator ! kde ! org
[Download RAW message or body]
dkardarakos created this revision.
dkardarakos added a reviewer: KDE Edu.
dkardarakos added a project: KDE Edu.
REVISION SUMMARY
On-line dictionaries, until now, were hard coded to browser widget class. Instead \
of this, a new section has been added to configuration: Dictionaries. This section \
consists of a list of dictionaries and as a set of three buttons: Add, Edit, Remove. \
Initially, the list is loaded with the previously-hard coded dictionary entries, \
which are now configuration defaults. User may select an existing dictionary and edit \
or remove it. In case of editing, a dialog opens that enables the user to edit name, \
url, source language and target language. Moreover, user may press Add button so as \
to add a new dictionary entry. Finally, a set of error handling rules have been \
added, preventing the user from adding an entry with empty name or url.
TEST PLAN
Check that in Settings, Dictionaries section has been added, containing a set of \
on-line dictionaries
Add Dictionary
- In Settings->Dictionaries, click Add. An editor opens. Add a new dictionary \
entry. Click OK.
A new dictionary is added to the list.
Update Dictionary
- In Settings->Dictionaries, select a dictionary, click Add. An editor opens. Edit \
an existing dictionary entry. Click OK.
Dictionary has been updated.
Remove Dictionary
- In Settings->Dictionaries, select a dictionary, click Remove.
Dictionary is removed from the list.
Check buttons
- In Settings->Dictionaries, ensure that no dictionary is selected.
Edit, Remove buttons are not available.
Apply
- In Settings->Dictionaries, Add, Edit, Remove some dictionaries. Press OK/Apply.
In Browser Widget, dictionary list displays the updated dictionary list.
REPOSITORY
R340 Parley
REVISION DETAIL
https://phabricator.kde.org/D9395
AFFECTED FILES
src/CMakeLists.txt
src/editor/browserwidget.cpp
src/editor/browserwidget.h
src/editor/editor.cpp
src/editor/editor.h
src/settings/dictionaryeditor.cpp
src/settings/dictionaryeditor.h
src/settings/dictionaryeditor.ui
src/settings/parley.kcfg
src/settings/parleyprefs.cpp
src/settings/parleyprefs.h
src/settings/webdictionary.ui
src/settings/webdictoptions.cpp
src/settings/webdictoptions.h
src/settings/webdictoptions.ui
To: dkardarakos, #kde_edu
Cc: narvaez, apol
[Attachment #3 (unknown)]
<table><tr><td style="">dkardarakos created this revision.<br />dkardarakos added a \
reviewer: KDE Edu.<br />dkardarakos added a project: KDE Edu. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9395" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>On-line dictionaries, until now, were hard coded to browser \
widget class. Instead of this, a new section has been added to configuration: \
Dictionaries. This section consists of a list of dictionaries and as a set of three \
buttons: Add, Edit, Remove. Initially, the list is loaded with the previously-hard \
coded dictionary entries, which are now configuration defaults. User may select an \
existing dictionary and edit or remove it. In case of editing, a dialog opens that \
enables the user to edit name, url, source language and target language. Moreover, \
user may press Add button so as to add a new dictionary entry. Finally, a set of \
error handling rules have been added, preventing the user from adding an entry with \
empty name or url.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Check \
that in Settings, Dictionaries section has been added, containing a set of on-line \
dictionaries</p>
<p>Add Dictionary</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">In Settings->Dictionaries, click Add. An editor \
opens. Add a new dictionary entry. Click OK.</li> </ul>
<p>A new dictionary is added to the list.</p>
<p>Update Dictionary</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">In Settings->Dictionaries, select a dictionary, \
click Add. An editor opens. Edit an existing dictionary entry. Click OK.</li> </ul>
<p>Dictionary has been updated.</p>
<p>Remove Dictionary</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">In Settings->Dictionaries, select a dictionary, \
click Remove.</li> </ul>
<p>Dictionary is removed from the list.</p>
<p>Check buttons</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">In Settings->Dictionaries, ensure that no \
dictionary is selected.</li> </ul>
<p>Edit, Remove buttons are not available.</p>
<p>Apply</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">In Settings->Dictionaries, Add, Edit, Remove some \
dictionaries. Press OK/Apply.</li> </ul>
<p>In Browser Widget, dictionary list displays the updated dictionary \
list.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R340 \
Parley</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9395" \
rel="noreferrer">https://phabricator.kde.org/D9395</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>src/CMakeLists.txt<br /> \
src/editor/browserwidget.cpp<br /> src/editor/browserwidget.h<br />
src/editor/editor.cpp<br />
src/editor/editor.h<br />
src/settings/dictionaryeditor.cpp<br />
src/settings/dictionaryeditor.h<br />
src/settings/dictionaryeditor.ui<br />
src/settings/parley.kcfg<br />
src/settings/parleyprefs.cpp<br />
src/settings/parleyprefs.h<br />
src/settings/webdictionary.ui<br />
src/settings/webdictoptions.cpp<br />
src/settings/webdictoptions.h<br />
src/settings/webdictoptions.ui</div></div></div><br /><div><strong>To: \
</strong>dkardarakos, KDE Edu<br /><strong>Cc: </strong>narvaez, apol<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic