[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D9187: [Parley] Bugfix: StatisticsView doesn't display correct values
From:       Hartmut Riesenbeck <noreply () phabricator ! kde ! org>
Date:       2017-12-04 21:23:18
Message-ID: differential-rev-PHID-DREV-av3sfkfk6dsmehdr5lst-req () phabricator ! kde ! org
[Download RAW message or body]

hriesenbeck created this revision.
hriesenbeck added a reviewer: KDE Edu.
Restricted Application added a project: KDE Edu.

REVISION SUMMARY
  The color bars in LessonStatisticsView show only the correct values
  when the widget was just created. Changing practice language, mode or
  direction doesn't change the displayed values.
  
  Added missing method calls in StatisticsMainWindow slot methods.
  Implemented improved word counting for gender, conjugation and
  comparison practice, to provide correct statistics values for this
  practice modes.
  
  Removed wrongly displayed horizontal scroll bar in LessonStatisticsView.
  Modified column width calculation, not to use a hard coded magic number,
  which does not fit to plasma anymore. Use instead the viewport width of
  the LessonStatisticsView widget.
  
  BUG: 387602

REPOSITORY
  R340 Parley

BRANCH
  bugfix_statisticswin_for_review

REVISION DETAIL
  https://phabricator.kde.org/D9187

AFFECTED FILES
  .arcconfig
  src/collection/readonlycontainermodel.h
  src/statistics/conjugationoptions.cpp
  src/statistics/conjugationoptions.h
  src/statistics/lessonstatisticsview.cpp
  src/statistics/lessonstatisticsview.h
  src/statistics/statisticsmainwindow.cpp
  src/statistics/statisticsmainwindow.h
  src/statistics/statisticsmodel.cpp
  src/statistics/statisticsmodel.h
  src/utils.cpp
  src/utils.h

To: hriesenbeck, #kde_edu
Cc: narvaez, apol

[Attachment #3 (unknown)]

<table><tr><td style="">hriesenbeck created this revision.<br />hriesenbeck added a \
reviewer: KDE Edu.<br />Restricted Application added a project: KDE Edu. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9187" \
rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>The color bars in LessonStatisticsView show only the correct \
values<br /> when the widget was just created. Changing practice language, mode or<br \
/> direction doesn&#039;t change the displayed values.</p>

<p>Added missing method calls in StatisticsMainWindow slot methods.<br />
Implemented improved word counting for gender, conjugation and<br />
comparison practice, to provide correct statistics values for this<br />
practice modes.</p>

<p>Removed wrongly displayed horizontal scroll bar in LessonStatisticsView.<br />
Modified column width calculation, not to use a hard coded magic number,<br />
which does not fit to plasma anymore. Use instead the viewport width of<br />
the LessonStatisticsView widget.</p>

<p>BUG: 387602</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R340 \
Parley</div></div></div><br \
/><div><strong>BRANCH</strong><div><div>bugfix_statisticswin_for_review</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D9187" \
rel="noreferrer">https://phabricator.kde.org/D9187</a></div></div><br \
/><div><strong>AFFECTED FILES</strong><div><div>.arcconfig<br /> \
src/collection/readonlycontainermodel.h<br /> \
src/statistics/conjugationoptions.cpp<br /> src/statistics/conjugationoptions.h<br />
src/statistics/lessonstatisticsview.cpp<br />
src/statistics/lessonstatisticsview.h<br />
src/statistics/statisticsmainwindow.cpp<br />
src/statistics/statisticsmainwindow.h<br />
src/statistics/statisticsmodel.cpp<br />
src/statistics/statisticsmodel.h<br />
src/utils.cpp<br />
src/utils.h</div></div></div><br /><div><strong>To: </strong>hriesenbeck, KDE Edu<br \
/><strong>Cc: </strong>narvaez, apol<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]