[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D7852: Progress bar corresponding to clicked zone only will be animated
From:       Rohit Das <noreply () phabricator ! kde ! org>
Date:       2017-10-27 14:33:21
Message-ID: 20171027143306.79162.EB3C99D47E080EF3 () phabricator ! kde ! org
[Download RAW message or body]

rohitdas added inline comments.

INLINE COMMENTS

> GoalZone.qml:61
> +    }
> +
> +    function changeBallState(GoalZone) {

Should I change this function back to the ternary expression?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D7852

To: rohitdas, #gcompris_improvements, #gcompris, rudranilbasu
Cc: rudranilbasu, dmadaan, #kde_edu, jjazeix, nityanandkumar, echarruau, rahulyadav, \
narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin


[Attachment #3 (unknown)]

<table><tr><td style="">rohitdas added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7852" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7852#inline-36790" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">GoalZone.qml:61</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">    <span class="p">}</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">    <span style="color: #aa4000">function</span> <span style="color: \
#004012">changeBallState</span><span class="p">(</span><span style="color: \
#004012">GoalZone</span><span class="p">)</span> <span class="p">{</span> \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Should I change this function back to the ternary \
expression?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7852" \
rel="noreferrer">https://phabricator.kde.org/D7852</a></div></div><br \
/><div><strong>To: </strong>rohitdas, GCompris: Improvements, GCompris, \
rudranilbasu<br /><strong>Cc: </strong>rudranilbasu, dmadaan, KDE Edu, jjazeix, \
nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, \
hkaelberer, bcoudoin<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]