[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    D8349: Fixed bug when sometimes feft part of some elements' text can disappear when expanded.
From:       Aman Kumar Gupta <noreply () phabricator ! kde ! org>
Date:       2017-10-22 15:44:49
Message-ID: 20171022154449.49299.11FA85A3CFCEB6A3 () phabricator ! kde ! org
[Download RAW message or body]

amankumargupta added inline comments.

INLINE COMMENTS

> jjazeix wrote in LetterInWord.qml:292
> the other one?

oops, sorry. I think by mistake i had set topMargin: background.itemWidth * 0.5 , \
instead of leftMargin while creating the patch. However, I'll rework \
https://phabricator.kde.org/T5935 and update the correct diff to this then, if needed \
:)

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D8349

To: amankumargupta, jjazeix
Cc: jjazeix, #kde_edu, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, \
apol, timotheegiet, hkaelberer, bcoudoin


[Attachment #3 (unknown)]

<table><tr><td style="">amankumargupta added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D8349" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D8349#inline-35888" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">jjazeix</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">LetterInWord.qml:292</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">the other one?</p></div></div> \
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">oops, sorry. I think by mistake i had set topMargin: background.itemWidth * 0.5 \
, instead of leftMargin while creating the patch. However, I&#039;ll rework <a \
href="https://phabricator.kde.org/T5935" class="remarkup-link" target="_blank" \
rel="noreferrer">https://phabricator.kde.org/T5935</a> and update the correct diff to \
this then, if needed :)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R2 GCompris</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D8349" \
rel="noreferrer">https://phabricator.kde.org/D8349</a></div></div><br \
/><div><strong>To: </strong>amankumargupta, jjazeix<br /><strong>Cc: \
</strong>jjazeix, KDE Edu, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, \
apol, timotheegiet, hkaelberer, bcoudoin<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]