[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 130224: fixes bug "Relative path for audio files not working"
From: Albert Astals Cid <aacid () kde ! org>
Date: 2017-08-15 7:57:32
Message-ID: 20170815075732.32443.51187 () mimi ! kde ! org
[Download RAW message or body]
--===============6063193506285887344==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 13, 2017, 3:42 p.m., Albert Astals Cid wrote:
> > Looks good, i'm going to go an extra step and ask.
> >
> > Do you think you could either add an autotest (or improve one of the existing \
> > ones) to check this so we don't regress again?
> > If you think it's too much or need help, just say it :)
>
> René Fritz wrote:
> Hi,
> Good point
> I'm a developer but totally new to c++, qt, ...
> So writing a test would be a bit too much for now, maybe?
>
> I don't see how keduvockvtml2reader.cpp could be tested easily. Too much context I \
> guess?
> So testing to read a whole document might be the way to go. I looked into the \
> existing tests. Kvtml2ReaderTest would be the right place I think and creating test \
> entries in the fixture xml is something I could do I guess. But testing the parsed \
> document would mean I understand the KVOCREADER_EXPECT_CORE macro to get access to \
> the parsed document ... which is not the case :-) A test example which takes
> XMLGenerator gen;
> and makes
> KEduVocDocument doc;
> out of it would be something I might be able to work with.
You don't really need KVOCREADER_EXPECT_CORE, the only thing that macro does is read \
the document and check it parsed successfully. You can't have access to the \
KEduVocDocument it contains.
Just create a new test_somethingSomething() function in Kvtml2ReaderTest and there \
declare all variables you need and QCOMPARE/QVERIFY in it
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130224/#review103606
-----------------------------------------------------------
On Aug. 12, 2017, 8:20 p.m., René Fritz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130224/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2017, 8:20 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Bugs: 381349
> https://bugs.kde.org/show_bug.cgi?id=381349
>
>
> Repository: libkeduvocdocument
>
>
> Description
> -------
>
> description is in bug report https://bugs.kde.org/show_bug.cgi?id=381349
>
>
> Diffs
> -----
>
> keduvocdocument/readerwriters/keduvockvtml2reader.cpp \
> d5322f51266da66247248776430efa0cb7f98fdc
> Diff: https://git.reviewboard.kde.org/r/130224/diff/
>
>
> Testing
> -------
>
> urls like "file:somepath/file.mp3" are parsed correctly again and sound is played
>
>
> Thanks,
>
> René Fritz
>
>
--===============6063193506285887344==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130224/">https://git.reviewboard.kde.org/r/130224/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 13th, 2017, 3:42 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Looks good, i'm going to go an extra step and ask.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Do you think you could either add an autotest (or \
improve one of the existing ones) to check this so we don't regress again?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">If you think it's too much or need help, just say it :)</p></pre> \
</blockquote>
<p>On August 13th, 2017, 8:58 p.m. UTC, <b>René Fritz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, \
Good point I'm a developer but totally new to c++, qt, ...
So writing a test would be a bit too much for now, maybe?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I don't see how keduvockvtml2reader.cpp could be \
tested easily. Too much context I guess?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">So testing to read a \
whole document might be the way to go. I looked into the existing tests. \
Kvtml2ReaderTest would be the right place I think and creating test entries in the \
fixture xml is something I could do I guess. But testing the parsed document would \
mean I understand the KVOCREADER_EXPECT_CORE macro to get access to the parsed \
document ... which is not the case :-) A test example which takes
XMLGenerator gen;
and makes
KEduVocDocument doc;
out of it would be something I might be able to work with.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
don't really need KVOCREADER_EXPECT_CORE, the only thing that macro does is read the \
document and check it parsed successfully. You can't have access to the \
KEduVocDocument it contains.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Just create a new \
test_somethingSomething() function in Kvtml2ReaderTest and there declare all \
variables you need and QCOMPARE/QVERIFY in it</p></pre> <br />
<p>- Albert</p>
<br />
<p>On August 12th, 2017, 8:20 p.m. UTC, René Fritz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By René Fritz.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2017, 8:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=381349">381349</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">description is in bug report \
https://bugs.kde.org/show_bug.cgi?id=381349</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">urls like "file:somepath/file.mp3" are parsed \
correctly again and sound is played</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keduvocdocument/readerwriters/keduvockvtml2reader.cpp <span style="color: \
grey">(d5322f51266da66247248776430efa0cb7f98fdc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130224/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6063193506285887344==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic