[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 130217: kbruch- Change QCheckBoxes under "Answer" section to QRadioButtons to avo
From: Aman Kumar Gupta <gupta2140 () gmail ! com>
Date: 2017-08-07 15:16:16
Message-ID: 20170807151616.23163.82908 () mimi ! kde ! org
[Download RAW message or body]
--===============7799818761130505066==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130217/#review103573
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Kumar Gupta
On Aug. 7, 2017, 1:47 p.m., Aman Kumar Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130217/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2017, 1:47 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Bugs: 357675
> http://bugs.kde.org/show_bug.cgi?id=357675
>
>
> Repository: kbruch
>
>
> Description
> -------
>
> Patch for Bug ID-357657. Replaced QCheckbox objects named "m_AnswerMixedCheck" and \
> "m_ReducedCheck" to QRadioButton to select only one option in displaying the type \
> of Answer(either Mixed Fraction or Reduced form).
>
> Diffs
> -----
>
> src/MainQtWidget.h dc62307
> src/MainQtWidget.cpp c522145
>
> Diff: https://git.reviewboard.kde.org/r/130217/diff/
>
>
> Testing
> -------
>
> It works successfully without any bugs fulfilling the objective of the patch. \
> QCheckBoxes under "Answer Section" replaced with QRadioButtons, changes reflected \
> to both, MainQtWidget.h as well as MainQtWidget.cpp.
>
> File Attachments
> ----------------
>
> Before patch. Both options under "Answer" checked.
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/07376b4b-7726-4c81-a581-9019912db46d__Mixedreduced_both_checked.png
> Before patch. Both options under "Answer" unchecked.
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/ccbe2e4b-b623-42a3-a17b-ce28b0aca972__Both_unchecked.png
> After patch. Changed QCheckBoxes to QRadiobuttons
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/5f659ff6-648f-4a94-808a-ecb754263449__Mixed_check.png
> Only one option out of Mixed and Reduced can be selected.
> https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/9466711e-bf9e-4133-967f-7965bffd4254__Reduced_check.png
>
>
> Thanks,
>
> Aman Kumar Gupta
>
>
--===============7799818761130505066==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130217/">https://git.reviewboard.kde.org/r/130217/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Aman Kumar Gupta</p>
<br />
<p>On August 7th, 2017, 1:47 p.m. UTC, Aman Kumar Gupta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Aman Kumar Gupta.</div>
<p style="color: grey;"><i>Updated Aug. 7, 2017, 1:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=357675">357675</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kbruch
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Patch for Bug ID-357657. Replaced QCheckbox objects \
named "m_AnswerMixedCheck" and "m_ReducedCheck" to QRadioButton to select only one \
option in displaying the type of Answer(either Mixed Fraction or Reduced \
form).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It works successfully without any bugs fulfilling the \
objective of the patch. QCheckBoxes under "Answer Section" replaced with \
QRadioButtons, changes reflected to both, MainQtWidget.h as well as \
MainQtWidget.cpp.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainQtWidget.h <span style="color: grey">(dc62307)</span></li>
<li>src/MainQtWidget.cpp <span style="color: grey">(c522145)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130217/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/07376b4b-7726-4c81-a581-9019912db46d__Mixedreduced_both_checked.png">Before \
patch. Both options under "Answer" checked.</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/ccbe2e4b-b623-42a3-a17b-ce28b0aca972__Both_unchecked.png">Before \
patch. Both options under "Answer" unchecked.</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/5f659ff6-648f-4a94-808a-ecb754263449__Mixed_check.png">After \
patch. Changed QCheckBoxes to QRadiobuttons</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/08/05/9466711e-bf9e-4133-967f-7965bffd4254__Reduced_check.png">Only \
one option out of Mixed and Reduced can be selected.</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7799818761130505066==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic