[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 130125: parley: Fix invisible color text in statistics legend
From:       Dimitris Kardarakos <dimkard () gmail ! com>
Date:       2017-07-27 8:43:38
Message-ID: 20170727084338.30502.56560 () mimi ! kde ! org
[Download RAW message or body]

--===============4215800827078210644==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130125/
-----------------------------------------------------------

(Updated July 27, 2017, 8:43 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Hartmut Riesenbeck.


Changes
-------

Submitted with commit f45c5338dea632d6f7e01043d596b50c6ae751f4 by Albert Astals Cid \
on behalf of Dimitris Kardarakos to branch Applications/17.08.


Repository: parley


Description
-------

Since text color in statistics legend had been set to black, it was invisible when \
dark themes were used. With this fix, text color follows the user selected color \
theme.


Diffs
-----

  src/statistics/statisticslegendwidget.cpp 3195a0a 

Diff: https://git.reviewboard.kde.org/r/130125/diff/


Testing
-------

Legend is displayed properly using Breeze or Breeze Dark.


File Attachments
----------------

Legend before
  https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/1d4dee19-6923-4d71-a1cf-e84f204b5415__legend_before.png
 Legend after
  https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/4785afd7-120b-4a74-aaf9-7902222e6b6f__legend_after.png
 Legend before
  https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/199e1858-fcd7-41fb-a81c-2d9bb129d1b9__legend_before.png
 Legend after
  https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/763669bb-a161-48a1-a08e-2da8d8295e78__legend_after.png
 fixLegendColor.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2017/07/26/8027a0f5-3597-4238-9d39-c44068b3ca15__fixLegendColor.patch
 fixLegendColor.patch
  https://git.reviewboard.kde.org/media/uploaded/files/2017/07/26/cd9c211b-c938-49ce-9541-e1036d57be36__fixLegendColor.patch



Thanks,

Dimitris Kardarakos


--===============4215800827078210644==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/130125/">https://git.reviewboard.kde.org/r/130125/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Hartmut Riesenbeck.</div>
<div>By Dimitris Kardarakos.</div>


<p style="color: grey;"><i>Updated July 27, 2017, 8:43 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit f45c5338dea632d6f7e01043d596b50c6ae751f4 by Albert \
Astals Cid on behalf of Dimitris Kardarakos to branch Applications/17.08.</pre>  \
</td>  </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Since text color in statistics legend had been set to \
black, it was invisible when dark themes were used. With this fix, text color follows \
the user selected color theme.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Legend is displayed properly using Breeze or Breeze \
Dark.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/statistics/statisticslegendwidget.cpp <span style="color: \
grey">(3195a0a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/130125/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/1d4dee19-6923-4d71-a1cf-e84f204b5415__legend_before.png">Legend \
before</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/4785afd7-120b-4a74-aaf9-7902222e6b6f__legend_after.png">Legend \
after</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/199e1858-fcd7-41fb-a81c-2d9bb129d1b9__legend_before.png">Legend \
before</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/05/11/763669bb-a161-48a1-a08e-2da8d8295e78__legend_after.png">Legend \
after</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/07/26/8027a0f5 \
-3597-4238-9d39-c44068b3ca15__fixLegendColor.patch">fixLegendColor.patch</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/07/26/cd9c211b \
-c938-49ce-9541-e1036d57be36__fixLegendColor.patch">fixLegendColor.patch</a></li>

</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4215800827078210644==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic