[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 130124: parley: Add locale name to column title
From: Albert Astals Cid <aacid () kde ! org>
Date: 2017-07-02 22:29:37
Message-ID: 20170702222937.5106.17792 () mimi ! kde ! org
[Download RAW message or body]
--===============9071691190064574950==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130124/#review103400
-----------------------------------------------------------
src/collection/vocabularymodel.cpp (line 293)
<https://git.reviewboard.kde.org/r/130124/#comment68819>
You're assuming all the languages in the world want the locale at the \
end, use %1
- Albert Astals Cid
On mai. 10, 2017, 9:44 a.m., Dimitris Kardarakos wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130124/
> -----------------------------------------------------------
>
> (Updated mai. 10, 2017, 9:44 a.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: parley
>
>
> Description
> -------
>
> In editor mode, when the same column is displayed, coming from different \
> languages, it is impossible to find out the source language. E.g. when \
> Word Type is visible, for both English and Spanish, both columns are \
> displayed as Word Type, at the header of the table. In terms of this \
> solution, locale name has been added to each column title (since it is \
> more compact than language name).
>
> Diffs
> -----
>
> src/collection/vocabularymodel.h 846f39b
> src/collection/vocabularymodel.cpp 582701b
> src/editor/vocabularycolumnsdialog.cpp fc08c1e
>
> Diff: https://git.reviewboard.kde.org/r/130124/diff/
>
>
> Testing
> -------
>
> Collections have been edited and practiced and everything worked as \
> expected.
>
> File Attachments
> ----------------
>
> Columns before
> https://git.reviewboard.kde.org/media/uploaded/files/2017/05/10/23f51bc0-e4a9-4372-a03f-6207d467fc95__parley_before.png
> Columns after
> https://git.reviewboard.kde.org/media/uploaded/files/2017/05/10/e4990fd0-c78b-44b8-a0ca-ec9a781080bc__parley_after.png
>
>
> Thanks,
>
> Dimitris Kardarakos
>
>
--===============9071691190064574950==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130124/">https://git.reviewboard.kde.org/r/130124/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid \
#C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid \
#C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/130124/diff/1/?file=495659#file495659line293" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/collection/vocabularymodel.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">292</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">"Pronunciation"</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">293</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">i18n</span><span \
class="p">(</span><span class="s">"Pronunciation"</span><span \
class="p">)</span><span class="hl"> </span><span class="o"><span \
class="hl">+</span></span><span class="hl"> </span><span class="n"><span \
class="hl">localeSuffix</span></span><span class="p">;</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">You're assuming all the \
languages in the world want the locale at the end, use %1</p></pre> </div>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On maig 10th, 2017, 9:44 a.m. UTC, Dimitris Kardarakos wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Dimitris Kardarakos.</div>
<p style="color: grey;"><i>Updated mai. 10, 2017, 9:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">In editor mode, when the same \
column is displayed, coming from different languages, it is impossible to \
find out the source language. E.g. when Word Type is visible, for both \
English and Spanish, both columns are displayed as Word Type, at the header \
of the table. In terms of this solution, locale name has been added to each \
column title (since it is more compact than language name).</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Collections have been edited \
and practiced and everything worked as expected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/collection/vocabularymodel.h <span style="color: \
grey">(846f39b)</span></li>
<li>src/collection/vocabularymodel.cpp <span style="color: \
grey">(582701b)</span></li>
<li>src/editor/vocabularycolumnsdialog.cpp <span style="color: \
grey">(fc08c1e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130124/diff/" \
style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File \
Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/05/10/23f51bc0-e4a9-4372-a03f-6207d467fc95__parley_before.png">Columns \
before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/05/10/e4990fd0-c78b-44b8-a0ca-ec9a781080bc__parley_after.png">Columns \
after</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9071691190064574950==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic