[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Review Request 130124: parley: Add locale name to column title
From:       Dimitris Kardarakos <dimkard () gmail ! com>
Date:       2017-05-10 9:44:50
Message-ID: 20170510094450.30377.76396 () mimi ! kde ! org
[Download RAW message or body]

--===============4656053900134796479==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130124/
-----------------------------------------------------------

Review request for KDE Edu.


Repository: parley


Description
-------

In editor mode, when the same column is displayed, coming from different languages, \
it is impossible to find out the source language. E.g. when Word Type is visible, for \
both English and Spanish, both columns are displayed as Word Type, at the header of \
the table. In terms of this solution, locale name has been added to each column title \
(since it is more compact than language name).


Diffs
-----

  src/collection/vocabularymodel.h 846f39b 
  src/collection/vocabularymodel.cpp 582701b 
  src/editor/vocabularycolumnsdialog.cpp fc08c1e 

Diff: https://git.reviewboard.kde.org/r/130124/diff/


Testing
-------

Collections have been edited and practiced and everything worked as expected.


Thanks,

Dimitris Kardarakos


--===============4656053900134796479==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/130124/">https://git.reviewboard.kde.org/r/130124/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Dimitris Kardarakos.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In editor mode, when the same column is displayed, \
coming from different languages, it is impossible to find out the source language. \
E.g. when Word Type is visible, for both English and Spanish, both columns are \
displayed as Word Type, at the header of the table. In terms of this solution, locale \
name has been added to each column title (since it is more compact than language \
name).</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Collections have been edited and practiced and \
everything worked as expected.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/collection/vocabularymodel.h <span style="color: grey">(846f39b)</span></li>

 <li>src/collection/vocabularymodel.cpp <span style="color: \
grey">(582701b)</span></li>

 <li>src/editor/vocabularycolumnsdialog.cpp <span style="color: \
grey">(fc08c1e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/130124/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4656053900134796479==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic