[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 130104: kgeography: Add location name in results table
From:       Dimitris Kardarakos <dimkard () gmail ! com>
Date:       2017-04-25 21:18:55
Message-ID: 20170425211855.803.6071 () mimi ! kde ! org
[Download RAW message or body]

--===============5668674041153581344==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130104/
-----------------------------------------------------------

(Updated April 25, 2017, 9:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Bugs: 141442
    http://bugs.kde.org/show_bug.cgi?id=141442


Repository: kgeography


Description
-------

In "Location of Countries" quiz, the table of results displays only the color of the \
user answer. As mentioned in bug report, in maps with many countries, it could be \
useful to display the name of the location selected by the user. So, results table \
has been enhanced displaying location names as well.


Diffs
-----

  src/answer.cpp 404d409 
  src/map.h a1db524 
  src/map.cpp 5bb723b 
  src/mapasker.cpp c5f1113 

Diff: https://git.reviewboard.kde.org/r/130104/diff/


Testing
-------

Executed quiz of putting locations to map, using various maps. Results table displays \
the name of the selected by the user location.


Thanks,

Dimitris Kardarakos


--===============5668674041153581344==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/130104/">https://git.reviewboard.kde.org/r/130104/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Dimitris Kardarakos.</div>


<p style="color: grey;"><i>Updated April 25, 2017, 9:18 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=141442">141442</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In "Location of Countries" quiz, the table of results \
displays only the color of the user answer. As mentioned in bug report, in maps with \
many countries, it could be useful to display the name of the location selected by \
the user. So, results table has been enhanced displaying location names as \
well.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Executed quiz of putting locations to map, using \
various maps. Results table displays the name of the selected by the user \
location.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/answer.cpp <span style="color: grey">(404d409)</span></li>

 <li>src/map.h <span style="color: grey">(a1db524)</span></li>

 <li>src/map.cpp <span style="color: grey">(5bb723b)</span></li>

 <li>src/mapasker.cpp <span style="color: grey">(c5f1113)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/130104/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============5668674041153581344==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic