[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 129873: Fix build with extra-cmake-modules > 5.30
From:       Heiko Becker <heirecka () exherbo ! org>
Date:       2017-01-22 22:34:26
Message-ID: 20170122223426.19722.630 () mimi ! kde ! org
[Download RAW message or body]

--===============1274958772834363560==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129873/
-----------------------------------------------------------

(Updated Jan. 22, 2017, 10:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Andreas Cord-Landwehr.


Changes
-------

Submitted with commit 04048799910fc423a5fa100a1c46b91dbe8e7e61 by Heiko Becker to \
branch master.


Repository: kalzium


Description
-------

Since a5f3a76e14799c68b5e8f74e375baa5f6f6ab4dc in
extra-cmake-modules.git -fno-operator-names is passed to the build
(when supported), causing a build error for kalzium.


Diffs
-----

  src/calculator/titrationCalculator.cpp 44ea1527 

Diff: https://git.reviewboard.kde.org/r/129873/diff/


Testing
-------

Builds fine now with ecm > 5.30.0


Thanks,

Heiko Becker


--===============1274958772834363560==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129873/">https://git.reviewboard.kde.org/r/129873/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Andreas Cord-Landwehr.</div>
<div>By Heiko Becker.</div>


<p style="color: grey;"><i>Updated Jan. 22, 2017, 10:34 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 04048799910fc423a5fa100a1c46b91dbe8e7e61 by Heiko \
Becker to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kalzium
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since a5f3a76e14799c68b5e8f74e375baa5f6f6ab4dc in \
extra-cmake-modules.git -fno-operator-names is passed to the build (when supported), \
causing a build error for kalzium.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds fine now with ecm &gt; 5.30.0</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/calculator/titrationCalculator.cpp <span style="color: \
grey">(44ea1527)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129873/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1274958772834363560==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic