'Re: Review Request 123968: Simplify Finding GSL in CMake'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 123968: Simplify Finding GSL in CMake
From:       Stefan Gerlach <stefan.gerlach () uni-konstanz ! de>
Date:       2016-12-08 20:59:29
Message-ID: 20161208205929.13487.27034 () mimi ! kde ! org
[Download RAW message or body]

--===============6676970652454759078==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/#review101334
-----------------------------------------------------------



Minimum cmake version is now 3.2.0 in the frameworks branch and we use FindGSL from \
now on.

- Stefan Gerlach


On June 30, 2015, 10:41 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123968/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 10:41 a.m.)
> 
> 
> Review request for KDE Edu and Marko Käning.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> Use the PkgConfig module. Setting compile definitions HAVE_GSL and GSL_VERSION has \
> no effect in the code so I removed them. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 980909c5b7b3effe70f0478f5e2128870f342e8f 
> src/CMakeLists.txt a70299a6b29dbf6703d255f7b9b1c05b4a457da1 
> 
> Diff: https://git.reviewboard.kde.org/r/123968/diff/
> 
> 
> Testing
> -------
> 
> Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this \
> still works in the OSX configuration, Marko? 
> 
> Thanks,
> 
> David Narváez
> 
> 


--===============6676970652454759078==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123968/">https://git.reviewboard.kde.org/r/123968/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Minimum cmake version is now 3.2.0 in the frameworks branch and we use \
FindGSL from now on.</p></pre>  <br />









<p>- Stefan Gerlach</p>


<br />
<p>On June 30th, 2015, 10:41 a.m. UTC, David Narváez wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Marko Käning.</div>
<div>By David Narváez.</div>


<p style="color: grey;"><i>Updated June 30, 2015, 10:41 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
labplot
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Use the PkgConfig module. Setting compile definitions \
HAVE_GSL and GSL_VERSION has no effect in the code so I removed them.</p></pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiled with make VERBOSE=1 to see the compile \
commands. I am not sure if this still works in the OSX configuration, \
Marko?</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(980909c5b7b3effe70f0478f5e2128870f342e8f)</span></li>

 <li>src/CMakeLists.txt <span style="color: \
grey">(a70299a6b29dbf6703d255f7b9b1c05b4a457da1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123968/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============6676970652454759078==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic