'Re: Review Request 128536: [parley] Change version string to script generated KDE Applications Versi'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 128536: [parley] Change version string to script generated KDE Applications Versi
From:       Hartmut Riesenbeck <hartmut.riesenbeck () gmx ! de>
Date:       2016-11-16 19:38:20
Message-ID: 20161116193820.5140.31013 () mimi ! kde ! org
[Download RAW message or body]

--===============8679967196152703054==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128536/
-----------------------------------------------------------

(Updated Nov. 16, 2016, 7:38 nachm.)


Review request for KDE Edu.


Changes
-------

Updated KDE Application version manually.
May this tiny but usefull feature is worth for the upcomming release?


Repository: parley


Description
-------

Since I noticed that parleys version string didn't changed for quite a long time, I make the suggestion \
to set it to the KDE Applications version like in many other KDE applications.

For my implementation I used the method descrbied here:
https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning

This has the advantage that the version string is automaticly set to the current KDE Applictions Version \
by script. Wich makes it much easier to associate bugs from the bug tracking system the the appropriate \
version.

The patch shows both - the program version and the KDE Applications Version. For the vocabulary document \
file only the program version is used.


Diffs (updated)
-----

  CMakeLists.txt dbc7a3f72e02d77d9e76338fe829852760affce4 
  config-parley.h.cmake fba6bdb49c652cd15282a9cbafdf044202f2976b 
  src/main.cpp 4a48b3f91db56cc8734ddd158673b5bce823b563 

Diff: https://git.reviewboard.kde.org/r/128536/diff/


Testing
-------


Thanks,

Hartmut Riesenbeck


--===============8679967196152703054==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128536/">https://git.reviewboard.kde.org/r/128536/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>


<p style="color: grey;"><i>Updated Nov. 16, 2016, 7:38 nachm.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Updated KDE Application version manually. \
May this tiny but usefull feature is worth for the upcomming release?</p></pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Since I noticed that parleys version string \
didn't changed for quite a long time, I make the suggestion to set it to the KDE Applications version \
like in many other KDE applications.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">For my implementation I used the method descrbied here: \
https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This has the advantage \
that the version string is automaticly set to the current KDE Applictions Version by script. Wich makes \
it much easier to associate bugs from the bug tracking system the the appropriate version.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch \
shows both - the program version and the KDE Applications Version. For the vocabulary document file only \
the program version is used.</p></pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(dbc7a3f72e02d77d9e76338fe829852760affce4)</span></li>

 <li>config-parley.h.cmake <span style="color: \
grey">(fba6bdb49c652cd15282a9cbafdf044202f2976b)</span></li>

 <li>src/main.cpp <span style="color: grey">(4a48b3f91db56cc8734ddd158673b5bce823b563)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128536/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8679967196152703054==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic