[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 128901: [Parley] Fix wrong displayed grade/pregrade in practise mode
From: Hartmut Riesenbeck <hartmut.riesenbeck () gmx ! de>
Date: 2016-10-30 19:28:00
Message-ID: 20161030192800.5235.48089 () mimi ! kde ! org
[Download RAW message or body]
--===============2940461980461552319==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128901/
-----------------------------------------------------------
(Updated Oct. 30, 2016, 8:28 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Changes
-------
Submitted with commit b2ddc4a2bf4147ad5c435d4199e1cfc8f4176aba by Hartmut Riesenbeck \
to branch master.
Repository: parley
Description
-------
The grade/pregrade display at the upper right corner of the practice
dialog fails for conjugation, gender of nouns and comparsion sessions.
The grades of the base entry were shown instead of the congugation
resp. article or comparsion ones.
The missing virtual methods in the appropriate backend classed were added.
Later it turned out that grade values are correct but pregrade values were displayed \
false. This was caused by a bug in libkeduvocdocument. The m_preGrade and m_intervall \
members of KEduVocText were not copied by the assignment operator. I posted a bugfix \
for review already. https://git.reviewboard.kde.org/r/128975/
So this patch won't work correct without the mentioned libkeduvocdocument patch.
BUG: 368749
Diffs
-----
src/practice/comparisonbackendmode.h f99dc3aa9d6cdf1128e72f24f3c079d02d9ad3bb
src/practice/comparisonbackendmode.cpp 2dcfe126ca851311aa48b5422c16189f3aedc03c
src/practice/conjugationbackendmode.cpp 7e05584a6ae0c39a137f07272ca810a51b08323a
src/practice/genderbackendmode.h 676e39cbd4434d26475c1464e53fca6c883a5775
src/practice/genderbackendmode.cpp 724e4c46e968f1ac337d5e11c3e36af5ce27fc69
src/practice/practicestatemachine.cpp bc03ffe01d7a6bf57a04508ea74f944825283138
Diff: https://git.reviewboard.kde.org/r/128901/diff/
Testing
-------
Manual testing
File Attachments
----------------
parley_wrong_grade_display.png
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/13/4ef6edf6-2d5b-4cb9-a830-c2a691443ca1__parley_wrong_grade_display.png
Thanks,
Hartmut Riesenbeck
--===============2940461980461552319==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128901/">https://git.reviewboard.kde.org/r/128901/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2016, 8:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit b2ddc4a2bf4147ad5c435d4199e1cfc8f4176aba by \
Hartmut Riesenbeck to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The grade/pregrade display at the upper right corner \
of the practice dialog fails for conjugation, gender of nouns and comparsion \
sessions. The grades of the base entry were shown instead of the congugation
resp. article or comparsion ones.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The missing virtual methods in the appropriate backend \
classed were added.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Later it turned out that grade values \
are correct but pregrade values were displayed false. This was caused by a bug in \
libkeduvocdocument. The m_preGrade and m_intervall members of KEduVocText were not \
copied by the assignment operator. I posted a bugfix for review already. \
https://git.reviewboard.kde.org/r/128975/ So this patch won't work correct without \
the mentioned libkeduvocdocument patch.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: 368749</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Manual testing</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/practice/comparisonbackendmode.h <span style="color: \
grey">(f99dc3aa9d6cdf1128e72f24f3c079d02d9ad3bb)</span></li>
<li>src/practice/comparisonbackendmode.cpp <span style="color: \
grey">(2dcfe126ca851311aa48b5422c16189f3aedc03c)</span></li>
<li>src/practice/conjugationbackendmode.cpp <span style="color: \
grey">(7e05584a6ae0c39a137f07272ca810a51b08323a)</span></li>
<li>src/practice/genderbackendmode.h <span style="color: \
grey">(676e39cbd4434d26475c1464e53fca6c883a5775)</span></li>
<li>src/practice/genderbackendmode.cpp <span style="color: \
grey">(724e4c46e968f1ac337d5e11c3e36af5ce27fc69)</span></li>
<li>src/practice/practicestatemachine.cpp <span style="color: \
grey">(bc03ffe01d7a6bf57a04508ea74f944825283138)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128901/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/09/13/4ef6edf6 \
-2d5b-4cb9-a830-c2a691443ca1__parley_wrong_grade_display.png">parley_wrong_grade_display.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2940461980461552319==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic