'Re: Review Request 128926: More robust version check for Sage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 128926: More robust version check for Sage
From:       Antonio Rojas <arojas () archlinux ! org>
Date:       2016-09-19 20:30:12
Message-ID: 20160919203012.26270.97156 () mimi ! kde ! org
[Download RAW message or body]

--===============4623802666768611086==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128926/
-----------------------------------------------------------

(Updated Sept. 19, 2016, 8:30 p.m.)


Review request for KDE Edu and Filipe Saraiva.


Repository: cantor


Description (updated)
-------

Version check for Sage is once again broken with the latest version. Instead of \
relying on parsing the sage banner, which is likely to break with changes in Sage \
output format, use the dedicated 'sage -v' command.


Diffs
-----

  src/backends/sage/sagesession.cpp bd2c3dc 

Diff: https://git.reviewboard.kde.org/r/128926/diff/


Testing
-------

Correct version is detected again according to the console output. Note that the \
backend is still broken with latest Sage, but that's a separate issue.


Thanks,

Antonio Rojas


--===============4623802666768611086==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128926/">https://git.reviewboard.kde.org/r/128926/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Filipe Saraiva.</div>
<div>By Antonio Rojas.</div>


<p style="color: grey;"><i>Updated Sept. 19, 2016, 8:30 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
cantor
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Version check for Sage is once again broken with the \
latest version. Instead of relying on parsing the sage banner, which is likely to \
break with changes in Sage output format, use the dedicated 'sage -v' \
command.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Correct version is detected again according to the \
console output. Note that the backend is still broken with latest Sage, but that's a \
separate issue.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backends/sage/sagesession.cpp <span style="color: \
grey">(bd2c3dc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128926/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4623802666768611086==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic