[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 128752: Mark invalid entries during practice and enable fixing in editor
From: Hartmut Riesenbeck <hartmut.riesenbeck () gmx ! de>
Date: 2016-09-12 14:36:55
Message-ID: 20160912143655.10006.45984 () mimi ! kde ! org
[Download RAW message or body]
--===============8618597419455732616==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128752/#review99128
-----------------------------------------------------------
Read your comment on Julians review (https://git.reviewboard.kde.org/r/127891/). I \
agree with you for that point of a more distinct workflow. My personal workflow is \
similar to your approach. I note the respective word on a paper - of course old \
school ;-) - and edit them after the learning session. Edit these invald words and \
may research for correctness during learning would disturb the learning session for \
my point of view. But one point I miss in your approach. If the number of \
vocabularies is very big, it's hard to find one or two invalid ones in the editor. A \
kind of filter, which shows only the invalid lines would be very helpfull.
- Hartmut Riesenbeck
On Aug. 25, 2016, 9:54 vorm., Dimitris Kardarakos wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128752/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2016, 9:54 vorm.)
>
>
> Review request for KDE Edu.
>
>
> Bugs: 170534
> http://bugs.kde.org/show_bug.cgi?id=170534
>
>
> Repository: parley
>
>
> Description
> -------
>
> During practicing, users may stumble upon an invalid entry
> (typo, wrong match, etc). To enable users to timely handle these entries, in
> practice main window, a new button (Invalid Entry) has been added. As soon as
> users click on it, the current entry is set as invalid (deactivated), it is
> excluded from the practice as well as from future practices. Session flow
> moves on to the next entry.After the completion of the practice (or later)
> users may navigate to the editor so as to fix invalid entries. These entries
> can be identified by their negative (red) color. In Edit menu, a new action
> to toggle activation status has been added. User may select a single or more
> entries and toggle their activation status after fixing them. Valid entries'
> color is set to non-negative again.
>
>
> Diffs
> -----
>
> src/collection/entryfilter.cpp a68c30d
> src/collection/testentry.h a43eb6f
> src/collection/testentry.cpp 3e152f1
> src/collection/vocabularymodel.cpp 582701b
> src/editor/editorui.rc c9c928e
> src/editor/vocabularyview.h 3730508
> src/editor/vocabularyview.cpp 2760c06
> src/practice/abstractfrontend.h f5f9552
> src/practice/guifrontend.cpp 4ee6348
> src/practice/practice_mainwindow.ui 00864ac
> src/practice/practicestatemachine.h b67ba32
> src/practice/practicestatemachine.cpp bc03ffe
>
> Diff: https://git.reviewboard.kde.org/r/128752/diff/
>
>
> Testing
> -------
>
> Start practice
> Mark 1st entry as invalid
> Mark 2nd entry as invalid
> Continue and finish
> View summary (the invalids are marked as unanswered)
> Open editor
> Fix an invalid entry
> Toggle activation status (so as to be included to future practices)
>
>
> File Attachments
> ----------------
>
> Short demo of the functionality
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/25/c011d3d0-8151-459e-98a5-39961fd812fc__parleyFixInvalids.webm
>
>
> Thanks,
>
> Dimitris Kardarakos
>
>
--===============8618597419455732616==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128752/">https://git.reviewboard.kde.org/r/128752/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Read \
your comment on Julians review (https://git.reviewboard.kde.org/r/127891/). I agree \
with you for that point of a more distinct workflow. My personal workflow is similar \
to your approach. I note the respective word on a paper - of course old school ;-) - \
and edit them after the learning session. Edit these invald words and may research \
for correctness during learning would disturb the learning session for my point of \
view. But one point I miss in your approach. If the number of vocabularies is very \
big, it's hard to find one or two invalid ones in the editor. A kind of filter, which \
shows only the invalid lines would be very helpfull.</p></pre> <br />
<p>- Hartmut Riesenbeck</p>
<br />
<p>On August 25th, 2016, 9:54 vorm. UTC, Dimitris Kardarakos wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Dimitris Kardarakos.</div>
<p style="color: grey;"><i>Updated Aug. 25, 2016, 9:54 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=170534">170534</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">During practicing, users may stumble upon an invalid \
entry (typo, wrong match, etc). To enable users to timely handle these entries, in
practice main window, a new button (Invalid Entry) has been added. As soon as
users click on it, the current entry is set as invalid (deactivated), it is
excluded from the practice as well as from future practices. Session flow
moves on to the next entry.After the completion of the practice (or later)
users may navigate to the editor so as to fix invalid entries. These entries
can be identified by their negative (red) color. In Edit menu, a new action
to toggle activation status has been added. User may select a single or more
entries and toggle their activation status after fixing them. Valid entries'
color is set to non-negative again.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Start practice Mark 1st entry as invalid
Mark 2nd entry as invalid
Continue and finish
View summary (the invalids are marked as unanswered)
Open editor
Fix an invalid entry
Toggle activation status (so as to be included to future practices)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/collection/entryfilter.cpp <span style="color: grey">(a68c30d)</span></li>
<li>src/collection/testentry.h <span style="color: grey">(a43eb6f)</span></li>
<li>src/collection/testentry.cpp <span style="color: grey">(3e152f1)</span></li>
<li>src/collection/vocabularymodel.cpp <span style="color: \
grey">(582701b)</span></li>
<li>src/editor/editorui.rc <span style="color: grey">(c9c928e)</span></li>
<li>src/editor/vocabularyview.h <span style="color: grey">(3730508)</span></li>
<li>src/editor/vocabularyview.cpp <span style="color: grey">(2760c06)</span></li>
<li>src/practice/abstractfrontend.h <span style="color: grey">(f5f9552)</span></li>
<li>src/practice/guifrontend.cpp <span style="color: grey">(4ee6348)</span></li>
<li>src/practice/practice_mainwindow.ui <span style="color: \
grey">(00864ac)</span></li>
<li>src/practice/practicestatemachine.h <span style="color: \
grey">(b67ba32)</span></li>
<li>src/practice/practicestatemachine.cpp <span style="color: \
grey">(bc03ffe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128752/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/25/c011d3d0-8151-459e-98a5-39961fd812fc__parleyFixInvalids.webm">Short \
demo of the functionality</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8618597419455732616==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic