[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: [cantor] src/backends: Impelemented command execution with DBUS
From:       Иван Лахтанов <ivan.lakhtanov () gmail ! com>
Date:       2016-08-25 11:35:07
Message-ID: CAGHwCt7NyTD8DSUdZ-+Pn8hP3WYcSPQx1WTiRXXS4SXf9ZnKsA () mail ! gmail ! com
[Download RAW message or body]

Hello!

Here is the changes for review: https://phabricator.kde.org/D2575

2016-08-25 12:17 GMT+03:00 Christoph Feck <cfeck@kde.org>:

> On Wednesday 24 August 2016 20:45:59 Ivan Lakhtanov wrote:
> > Git commit 7e6af394e4cbf34afd9041dfcfef80c42c1f96c7 by Ivan
> > Lakhtanov. Committed on 24/08/2016 at 18:44.
> > Pushed by ivanlakhtanov into branch 'master'.
> >
> > Impelemented command execution with DBUS
> >
> > Used Julia embedding. Features: execution, syntax errors,
> > exceptions, multiline input, printing of the last result.
> >
> > Julia path is detected automatically.
> >
> > [...]
> > Differential Revision: https://phabricator.kde.org/D2006
> > [...]
> > http://commits.kde.org/cantor/7e6af394e4cbf34afd9041dfcfef80c42c1f9
> > 6c7
>
> Hi Ivan,
>
> could you please add CMake stuff for compiling julia backend only if
> <julia/julia.h> was found?
>
> --
> Christoph Feck
> KDE Quality Team
> https://kdepepo.wordpress.com/
>



-- 
Best regards, Ivan Lakhtanov

[Attachment #3 (text/html)]

<div dir="ltr">Hello!<div><br></div><div>Here is the changes for review:  <a \
href="https://phabricator.kde.org/D2575">https://phabricator.kde.org/D2575</a></div></div><div \
class="gmail_extra"><br><div class="gmail_quote">2016-08-25 12:17 GMT+03:00 Christoph \
Feck <span dir="ltr">&lt;<a href="mailto:cfeck@kde.org" \
target="_blank">cfeck@kde.org</a>&gt;</span>:<br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wednesday 24 \
August 2016 20:45:59 Ivan Lakhtanov wrote:<br> &gt; Git commit \
7e6af394e4cbf34afd9041dfcfef80<wbr>c42c1f96c7 by Ivan<br> &gt; Lakhtanov. Committed \
on 24/08/2016 at 18:44.<br> &gt; Pushed by ivanlakhtanov into branch \
&#39;master&#39;.<br> &gt;<br>
&gt; Impelemented command execution with DBUS<br>
&gt;<br>
&gt; Used Julia embedding. Features: execution, syntax errors,<br>
&gt; exceptions, multiline input, printing of the last result.<br>
&gt;<br>
&gt; Julia path is detected automatically.<br>
&gt;<br>
&gt; [...]<br>
&gt; Differential Revision: <a \
href="https://phabricator.kde.org/">https://phabricator.kde.org/</a><wbr>D2006<br> \
&gt; [...]<br> &gt; <a \
href="http://commits.kde.org/cantor/">http://commits.kde.org/cantor/</a><wbr>7e6af394e4cbf34afd9041dfcfef80<wbr>c42c1f9<br>
 &gt; 6c7<br>
<br>
Hi Ivan,<br>
<br>
could you please add CMake stuff for compiling julia backend only if<br>
&lt;julia/julia.h&gt; was found?<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Christoph Feck<br>
KDE Quality Team<br>
<a href="https://kdepepo.wordpress.com/">https://kdepepo.wordpress.com/</a><br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Best regards, \
Ivan Lakhtanov</div></div> </div>



[prev in list] [next in list] [prev in thread] [next in thread]