'Re: Review Request 128256: [Parley] Replace deprecated libkeduvocdocument methods'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 128256: [Parley] Replace deprecated libkeduvocdocument methods
From:       Hartmut Riesenbeck <hartmut.riesenbeck () gmx ! de>
Date:       2016-06-24 20:48:39
Message-ID: 20160624204839.2369.91593 () mimi ! kde ! org
[Download RAW message or body]

--===============4985136609135765748==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128256/
-----------------------------------------------------------

(Updated June 24, 2016, 10:48 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu.

Changes
-------

Submitted with commit 84b5193e312b54faf8d1606cb27e0bad7fddbb7d by Hartmut Riesenbeck to branch \
master.

Repository: parley

Description
-------

With commit ddb743b of libkeduvocdocument some methods which returned
non const refereces to private member values of KEduVocTranslation have
been set as deprecated. These methods were replaced with new provided
ones.

Some unused lines were deleted to make the compiling free of warnings.

Diffs
-----

  src/collection/entryfilter.cpp 8d6ca047380ac9ba464a5a1b425215df9759a324 
  src/dashboard/collectionwidget.cpp 3d1ff3300cc86be7c4d341872e77d7bb4096f791 
  src/dashboard/dashboard.cpp 978935e080ce5ef07a84364af2c618f892180b50 
  src/editor/conjugationwidget.cpp d19d4fe7e7f23aec11192744c4cff6a576cbcbc6 
  src/editor/multiplechoicewidget.cpp b0412e82c5cdd00925c7f7c22dd801aac551ff56 
  src/practice/configure/generalpracticeoptions.cpp a4677bc84152d2cf019c48f972504151a468c760 
  src/practice/conjugationbackendmode.cpp b57595ea7d008de300cf0d87405f6e85d89a5552 
  src/practice/practicemainwindow.cpp 3ca2d4e92cc2ee2823c8430bad7d76001033c9d2 
  src/practice/sessionmanagerbase.cpp bb4d08ca228ff00feb52179e80527bde69b0925e 
  src/scripts/scripting/translation.h 5ef3ffe1eca6c7f309b182f9cee84f9559e0d9e2 
  src/scripts/scripting/translation.cpp e8845117a6e297822a0ed32d4841e46e67d71274 
  src/statistics/statisticslegendwidget.cpp 46d3a3434608602ab977c3aebde2308bfb13aaab 

Diff: https://git.reviewboard.kde.org/r/128256/diff/

Testing
-------

Tested manualy.

Thanks,

Hartmut Riesenbeck

--===============4985136609135765748==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128256/">https://git.reviewboard.kde.org/r/128256/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>

<p style="color: grey;"><i>Updated June 24, 2016, 10:48 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
84b5193e312b54faf8d1606cb27e0bad7fddbb7d by Hartmut Riesenbeck to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With commit \
ddb743b of libkeduvocdocument some methods which returned non const refereces to private member \
values of KEduVocTranslation have been set as deprecated. These methods were replaced with new \
provided ones.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Some unused lines were deleted to make the compiling free of warnings.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested \
manualy.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/collection/entryfilter.cpp <span style="color: \
grey">(8d6ca047380ac9ba464a5a1b425215df9759a324)</span></li>

 <li>src/dashboard/collectionwidget.cpp <span style="color: \
grey">(3d1ff3300cc86be7c4d341872e77d7bb4096f791)</span></li>

 <li>src/dashboard/dashboard.cpp <span style="color: \
grey">(978935e080ce5ef07a84364af2c618f892180b50)</span></li>

 <li>src/editor/conjugationwidget.cpp <span style="color: \
grey">(d19d4fe7e7f23aec11192744c4cff6a576cbcbc6)</span></li>

 <li>src/editor/multiplechoicewidget.cpp <span style="color: \
grey">(b0412e82c5cdd00925c7f7c22dd801aac551ff56)</span></li>

 <li>src/practice/configure/generalpracticeoptions.cpp <span style="color: \
grey">(a4677bc84152d2cf019c48f972504151a468c760)</span></li>

 <li>src/practice/conjugationbackendmode.cpp <span style="color: \
grey">(b57595ea7d008de300cf0d87405f6e85d89a5552)</span></li>

 <li>src/practice/practicemainwindow.cpp <span style="color: \
grey">(3ca2d4e92cc2ee2823c8430bad7d76001033c9d2)</span></li>

 <li>src/practice/sessionmanagerbase.cpp <span style="color: \
grey">(bb4d08ca228ff00feb52179e80527bde69b0925e)</span></li>

 <li>src/scripts/scripting/translation.h <span style="color: \
grey">(5ef3ffe1eca6c7f309b182f9cee84f9559e0d9e2)</span></li>

 <li>src/scripts/scripting/translation.cpp <span style="color: \
grey">(e8845117a6e297822a0ed32d4841e46e67d71274)</span></li>

 <li>src/statistics/statisticslegendwidget.cpp <span style="color: \
grey">(46d3a3434608602ab977c3aebde2308bfb13aaab)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128256/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4985136609135765748==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 