'Re: Review Request 128275: Pass -fext-numeric-literals to fix the build with Qt 5.7'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 128275: Pass -fext-numeric-literals to fix the build with Qt 5.7
From:       Heiko Becker <heirecka () exherbo ! org>
Date:       2016-06-23 21:46:52
Message-ID: 20160623214652.22783.92751 () mimi ! kde ! org
[Download RAW message or body]

--===============8670791471842433711==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128275/
-----------------------------------------------------------

(Updated June 23, 2016, 9:46 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu and Andreas Cord-Landwehr.

Changes
-------

Submitted with commit a3194c96250e4325c6af9b75a36d09516fe82420 by Heiko Becker to \
branch master.

Repository: rocs

Description
-------

Otherwise I get "error: unable to find numeric literal operator
'operator""Q' BOOST_DEFINE_MATH_CONSTANT(half, 5.000000000000000..."

Diffs
-----

  CMakeLists.txt 8e2c4e8 

Diff: https://git.reviewboard.kde.org/r/128275/diff/

Testing
-------

I assume this is due to Qt 5.7 requiring C++11 but to be honest I'm not entirely \
sure. However with this change, rocs builds fine again.

Thanks,

Heiko Becker

--===============8670791471842433711==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128275/">https://git.reviewboard.kde.org/r/128275/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Andreas Cord-Landwehr.</div>
<div>By Heiko Becker.</div>

<p style="color: grey;"><i>Updated June 23, 2016, 9:46 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit a3194c96250e4325c6af9b75a36d09516fe82420 by Heiko \
Becker to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
rocs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Otherwise I get &quot;error: unable to find numeric literal operator \
&#39;operator&quot;&quot;Q&#39; BOOST_DEFINE_MATH_CONSTANT(half, \
5.000000000000000...&quot;</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I assume this is due to Qt 5.7 requiring C++11 but to be honest I&#39;m \
not entirely sure. However with this change, rocs builds fine again.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(8e2c4e8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128275/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8670791471842433711==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 