[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu-devel
Subject:    Re: Review Request 128229: Remove the google_images.py script: Google image search API is not availa
From:       Alexander Potashev <aspotashev () gmail ! com>
Date:       2016-06-18 16:24:30
Message-ID: 20160618162430.5478.42600 () mimi ! kde ! org
[Download RAW message or body]

--===============1712527288255346717==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128229/
-----------------------------------------------------------

(Updated June 18, 2016, 6:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Andreas Cord-Landwehr.


Changes
-------

Submitted with commit 45c5fb4fd3c6635fe9ae8b37b367eb8bb22125ac by Alexander Potashev \
to branch Applications/16.04.


Bugs: 364373
    http://bugs.kde.org/show_bug.cgi?id=364373


Repository: parley


Description
-------

Remove the google_images.py script: Google image search API is not available anymore

BUG: 364373
REVIEW: 128229


Diffs
-----

  plugins/CMakeLists.txt 296b5eceebdcc99cfad791f689823e243dc404c2 
  plugins/google_images.desktop 37ce88487a860a20862967da0369a9d278117027 
  plugins/google_images.py c4ccd6acf1bf9b0e7ed94c24c445789a1b450f5b 
  plugins/google_images.ui b8dc772069e9951d118916829ccab7639f9e0871 

Diff: https://git.reviewboard.kde.org/r/128229/diff/


Testing
-------

Parley does not crash anymore after opening a vocabulary.


Thanks,

Alexander Potashev


--===============1712527288255346717==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128229/">https://git.reviewboard.kde.org/r/128229/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Andreas Cord-Landwehr.</div>
<div>By Alexander Potashev.</div>


<p style="color: grey;"><i>Updated June 18, 2016, 6:24 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 45c5fb4fd3c6635fe9ae8b37b367eb8bb22125ac by \
Alexander Potashev to branch Applications/16.04.</pre>  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=364373">364373</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove the google_images.py script: Google image \
search API is not available anymore</p> <p style="padding: 0;text-rendering: \
                inherit;margin: 0;line-height: inherit;white-space: inherit;">BUG: \
                364373
REVIEW: 128229</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Parley does not crash anymore after opening a \
vocabulary.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/CMakeLists.txt <span style="color: \
grey">(296b5eceebdcc99cfad791f689823e243dc404c2)</span></li>

 <li>plugins/google_images.desktop <span style="color: \
grey">(37ce88487a860a20862967da0369a9d278117027)</span></li>

 <li>plugins/google_images.py <span style="color: \
grey">(c4ccd6acf1bf9b0e7ed94c24c445789a1b450f5b)</span></li>

 <li>plugins/google_images.ui <span style="color: \
grey">(b8dc772069e9951d118916829ccab7639f9e0871)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128229/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============1712527288255346717==--


[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic