[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 128212: libkeduvocdocument: Non const references methods in KEduVocTranslation ar
From: Hartmut Riesenbeck <hartmut.riesenbeck () gmx ! de>
Date: 2016-06-16 20:16:06
Message-ID: 20160616201606.9803.87530 () mimi ! kde ! org
[Download RAW message or body]
--===============7554446954317134798==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128212/
-----------------------------------------------------------
(Updated June 16, 2016, 1:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Changes
-------
Submitted with commit ddb743b7e312e69d7f1eee9a3f4c25ef8031b27b by Hartmut Riesenbeck \
to branch master.
Repository: libkeduvocdocument
Description
-------
Two methods which returns non const refereces to private member values
of KEduVocTranslation have been set as deprecated. Alternative
getter/setter methods were added. The usage of the deprecated methods
in the library were refactored to new methods.
Diffs
-----
keduvocdocument/keduvockvtml2writer.cpp 682095503680ddf4fd2f1dfe3de8e94fc28fc69d
keduvocdocument/keduvoctranslation.h 2b72d7a516352ed6f1418d0b9d7a0ac56f511e42
keduvocdocument/keduvoctranslation.cpp c098060fe98679edd5f45cd451657d378d08cdd9
keduvocdocument/readerwriters/keduvockvtml2reader.cpp \
0bcb4bde0b3455f171002294aad4488abb175543 \
keduvocdocument/readerwriters/keduvockvtmlreader.cpp \
063ac7e2eba447334ea7ead7ba4ed17b3f361de8
Diff: https://git.reviewboard.kde.org/r/128212/diff/
Testing
-------
Unit tests passed.
Thanks,
Hartmut Riesenbeck
--===============7554446954317134798==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128212/">https://git.reviewboard.kde.org/r/128212/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Hartmut Riesenbeck.</div>
<p style="color: grey;"><i>Updated June 16, 2016, 1:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit ddb743b7e312e69d7f1eee9a3f4c25ef8031b27b by \
Hartmut Riesenbeck to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkeduvocdocument
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Two methods which returns non const refereces to private member values \
of KEduVocTranslation have been set as deprecated. Alternative getter/setter methods \
were added. The usage of the deprecated methods in the library were refactored to new \
methods.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Unit tests passed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keduvocdocument/keduvockvtml2writer.cpp <span style="color: \
grey">(682095503680ddf4fd2f1dfe3de8e94fc28fc69d)</span></li>
<li>keduvocdocument/keduvoctranslation.h <span style="color: \
grey">(2b72d7a516352ed6f1418d0b9d7a0ac56f511e42)</span></li>
<li>keduvocdocument/keduvoctranslation.cpp <span style="color: \
grey">(c098060fe98679edd5f45cd451657d378d08cdd9)</span></li>
<li>keduvocdocument/readerwriters/keduvockvtml2reader.cpp <span style="color: \
grey">(0bcb4bde0b3455f171002294aad4488abb175543)</span></li>
<li>keduvocdocument/readerwriters/keduvockvtmlreader.cpp <span style="color: \
grey">(063ac7e2eba447334ea7ead7ba4ed17b3f361de8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128212/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7554446954317134798==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic